Bug 417193 - Can't display conversations
Summary: Can't display conversations
Status: RESOLVED FIXED
Alias: None
Product: choqok
Classification: Applications
Component: Twitter (show other bugs)
Version: 1.7.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Mehrdad Momeny
URL:
Keywords:
: 397031 417359 422634 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-05 12:20 UTC by Antonio Rojas
Modified: 2020-06-08 14:18 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.8
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2020-02-05 12:20:33 UTC
SUMMARY

choqok 1.7.0 can't display full conversations on Twitter. Clicking on the "show conversation" icon on a tweet used to open a window with the full conversation. Now it only shows the original tweet, and the status bar displays an error: "Fetching new post failed, with error:Could not authenticate you". The tweets in the timeline can be retrieved correctly, so there is no actual issue with authentication.
Comment 1 Antonio Rojas 2020-02-08 11:18:12 UTC
https://phabricator.kde.org/D27236
Comment 2 Andrea Scarpino 2020-02-11 10:08:08 UTC
Git commit ce6fb139a7e9bd9b6aee825e4fc7fb34482cc77d by Andrea Scarpino.
Committed on 11/02/2020 at 10:08.
Pushed by scarpino into branch 'master'.

Fix retrieving Twitter conversations

Summary:
Fix a regression from 0ecc05c1 where choqok can no longer retrieve Twitter conversations due to a mismatch between the authorization header and the actual post url

This was already fixed for requestTimeLine in f8285c35 but not for fetchPost

Test Plan: Clicked on "Display conversation" in a tweet from the timeline, no more authorization errors and the conversation is displayed correctly

Reviewers: scarpino

Reviewed By: scarpino

Differential Revision: https://phabricator.kde.org/D27236

M  +1    -2    microblogs/twitter/twittermicroblog.cpp

https://invent.kde.org/kde/choqok/commit/ce6fb139a7e9bd9b6aee825e4fc7fb34482cc77d
Comment 3 Andrea Scarpino 2020-02-11 10:13:37 UTC
*** Bug 417359 has been marked as a duplicate of this bug. ***
Comment 4 Andrea Scarpino 2020-02-11 10:15:25 UTC
*** Bug 397031 has been marked as a duplicate of this bug. ***
Comment 5 Antonio Rojas 2020-06-08 14:18:22 UTC
*** Bug 422634 has been marked as a duplicate of this bug. ***