Created attachment 125659 [details] Expected behavior Okular should be able to do a text search on it's annotations. For example, a Pop-Up note annotated with "Hello world" should be displayed in Reviews Sidebar when user search for the word "Hello". Currently, Okular only do a search on the annotations Title, instead on it's content.
From my understanding, to do a search on the annotations' content would require a complete overhaul of how this review side panel functions. The currently implemented search line is only able to filter entities that appear in the tree/list. For example, you can search the annotations in this panel by their page number, their author, or their pop-up type. Example: (pagenumber) input: 5, output: Page 5, Page 25, Page 57 (pop-up type) input: write, output: Typewriter (author) input: adm, output: Administrator (author) input: jo, output: john Because the tree already has toggle options to filter by page, author, both, or neither, this kind of search is redundant. And how often is filtering by pop-up type useful? On the other hand, filtering by annotation content would require the content to appear in the tree (think this is possible, but not entirely sure), which has a limited amount of space. I think that we should instead provide optional functionality to provide a keyword or title to be associated with an annotation in lieu of its type. For example, if I make a note with the highlighter over a paragraph containing the history of Okular, I should be able to assign a title to it called "Okular History" and search "history" to find it in the review sidebar. If nothing is assigned, it should keep its current behavior.
Created attachment 142279 [details] attachment-31843-0.html Hello, everyone. I am a sophomore from India named Suhaas. I would like to work on Bug 417145. This is the first time I am contributing to an open-source project and ended up changing the assignee by mistake. I have reset it to "Okular developers" default. I am sorry about that. May I start working on it, if no one else is at it? Also, if I understand the discussion in the bug report correctly, the changes to be made are: 1. add a keyword/title text field in the pop-up window for annotations (which the user can leave empty if the user doesn't have any keyword/title in mind) between the Summary area and the Heading (with user name and date) area 2. display search results when the user types a title/keyword in the annotation search bar (like the names of users who create annotations is already displayed when searched in the same search field) Is this correct? I am sorry if I got something wrong. Are there any instructions/suggestions/pointers to know? Thanks Suhaas On Sat, Oct 9, 2021 at 6:04 PM Suhaas <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=417145 > > Suhaas <joshiesuhaas0@gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Assignee|joshiesuhaas0@gmail.com |okular-devel@kde.org > > -- > You are receiving this mail because: > You are the assignee for the bug.
1) No, this doesn't make any sense, where do you pretend to store that information? 2) Just search on the annotation contents (not sure if optionally or always, i guess we could add an option)
Possible duplicate: https://bugs.kde.org/show_bug.cgi?id=310704