Bug 417122 - Notification permission doesn't get stored
Summary: Notification permission doesn't get stored
Status: RESOLVED NOT A BUG
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-03 21:58 UTC by lod
Modified: 2023-02-02 10:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lod 2020-02-03 21:58:44 UTC
SUMMARY
When I allow a website to send a notification (check the box to remember), close the browser and restart it. The site has to ask for permission again, it will be granted aromatic, but the website shouldn't have to ask again.
If you enable desktop notifications on Youtube or Reddit this setting is disabled after you restart Falkon.

STEPS TO REPRODUCE
1. go to https://www.bennish.net/web-notifications.html
2. click Authorize
3. select Remember
4. click Allow
5. restart Falkon
6. go to https://www.bennish.net/web-notifications.html
7. click the "Show"-button

OBSERVED RESULT
After restarting Falkon. Notifications will not show until I click on Authorize again.


EXPECTED RESULT
After restarting Falkon. Notifications should show when pressing the "Show"-button

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: arch linux
(available in About System)
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.1
Falkon: 3.1.0 and latest master
Comment 1 Juraj 2020-02-12 10:35:14 UTC
Permission is stored.
The "problem" you are facing is that it was not given to the site when it was loaded and the site needs to ask for it (which if you checked "Remember" will be done automatically).
I believe most of the websites at first always ask for permission before filing notification, that is normal practice because you do not know what browser user use or if the notifications are allowed.
Comment 2 lod 2020-02-12 14:38:54 UTC
Did you even read what I wrote?

Try "STEPS TO REPRODUCE" in different browsers and you will see that this behavior is Falkon exclusive.

Don't tell me that "If you enable desktop notifications on Youtube or Reddit this setting is disabled after you restart Falkon." is normal practice...

And to add something. I haven't got a single notification from youtube or reddit yet. I guess there's another problem. (in about a week without restarting Falkon, after allow notifications)
Comment 3 Juraj 2020-02-15 16:17:53 UTC
I said where the "problem" is.
Which is not actually a problem because site should always request permission from browser before firing notifications.

If I go to site with test notifications like this:
https://web-push-book.gauntface.com/demos/notification-examples/
It works as it should (website asks for permission and it is granted or rejected based on saved settings).

Patches are welcome.
Comment 4 Juraj 2023-02-02 10:20:01 UTC
OK, I went over it again and I do not see this as a fault of the Falkon but a fault of test method.

From what I understand the website needs to always ask for permission (authorization) before it can display the notifications.
This is done by the "Authorize" button on the mentioned site.
When Falkon is instructed to remember the user choice to eg. "Allow" the notifications, Falkon remembers it and on the next "Authorize" it will grant the permission without user asking.