Bug 417079 - Device name is missing
Summary: Device name is missing
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Plasma
Component: applet (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-02 22:24 UTC by Christophe Marin
Modified: 2020-02-06 16:36 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
new tray menu (65.29 KB, image/png)
2020-02-02 22:24 UTC, Christophe Marin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Marin 2020-02-02 22:24:35 UTC
Created attachment 125632 [details]
new tray menu

Using master.

With the recent change, the device name are not informative.

See the attached screenshot. "Analog output" and "Line Out" is not informative if you don't know which card provides them.
Comment 1 gvgeo 2020-02-03 15:06:58 UTC
Thanks for the reports Christophe, they are really helpful.

This was by design. But maybe is better to display the device too, when there are more than one.

Will need VDG response before making any change.
Comment 2 Nate Graham 2020-02-03 15:18:25 UTC
The idea here was to use the generic terms "Speakers" and "Microphone" when there is only one input or output device. However that doesn't seem to be the case here. When we have multiple input devices or output devices, we should indeed show the device name for each one.

In fact, it might make more sense to show the device name instead of the description.
Comment 3 Kai Uwe Broulik 2020-02-03 15:19:23 UTC
Yeah I was also super confused by the "Line Output" and thought it was playing on some not plugged in device.
Comment 4 Nate Graham 2020-02-06 16:36:03 UTC
Git commit 1b737cfe66135a6afc574a8af3c76eef11ceff39 by Nate Graham, on behalf of George Vogiatzis.
Committed on 06/02/2020 at 16:35.
Pushed by ngraham into branch 'master'.

[Applet] Display device name when there is than one device

Summary:
Display both device name and port if there is more than one device.
Applies separately for playback and recording devices.

Reviewers: #plasma, #vdg, drosca, ngraham

Reviewed By: #vdg, ngraham

Subscribers: cgiboudeaux, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27138

M  +6    -17   applet/contents/ui/DeviceListItem.qml
M  +2    -2    applet/contents/ui/main.qml

https://commits.kde.org/plasma-pa/1b737cfe66135a6afc574a8af3c76eef11ceff39