Bug 417076 - Timeline time scale is not correctly modified when loading or creating project with non-default frame rate
Summary: Timeline time scale is not correctly modified when loading or creating projec...
Status: RESOLVED WORKSFORME
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: git-master
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-02 21:07 UTC by alriddoch
Modified: 2020-02-18 16:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing a 25fps project, but the timeline scale has 50fps. (86.42 KB, image/png)
2020-02-02 21:07 UTC, alriddoch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description alriddoch 2020-02-02 21:07:58 UTC
Created attachment 125629 [details]
Screenshot showing a 25fps project, but the timeline scale has 50fps.

SUMMARY

The default project profile for my kdenlive config has 50fps. When I create a New project with a profile of 25fps, or load a 25fps project from disc, the time scale at the top of the timeline is not correctly updated for the new project, and still shows 50fps.
By binary search of the recent commits, I have found this this issue was introduced in the following commit:

f9491a9e397777830ff02f1da94d80f09c015fc3 "Attempt to fix crash after profile change"

STEPS TO REPRODUCE
1. Load kdenlive with its default configuration. (e.g. 50fps)
2. Create a new empty project with a different fps (e.g. 25fps)
3. Manually set the timeline cursor to a non-zero position on the timeline.

OBSERVED RESULT
The numerical cursor position below the monitor does not match the position on the timeline scale, and the numbers on the timeline scale have the incorrect number of frames per second.


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Fedora 31, Linux 5.4.12
(available in About System)
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.66.0
Qt Version: 5.13.2

ADDITIONAL INFORMATION
The attached screenshot is a new empty 25fps project created after kdenlive was started with 50fps in the default profile. The highlighted title shows the correct project profile fps, and the indicator below the project monitor shows the correct position for the cursor of 00:05:00.
The highlighted cursor position on the timeline scale shows it is incorrectly at 00:02:25, and also that the scale has 50 frames per second. i.e. The position of the cursor is the correct number of frames from the start, but the wrong number of seconds.
Comment 1 Jean-Baptiste Mardelle 2020-02-03 07:42:51 UTC
Thanks for reporting and yes sorry stupid mistake on my side. Should be fixed now, please test
Comment 2 alriddoch 2020-02-03 18:57:52 UTC
Fix confirmed.
Thanks for the quick turnaround. :)
Comment 3 Bug Janitor Service 2020-02-18 04:33:11 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!