Bug 417048 - Don't show "Search for 'something' with" in context menu if Web shortcuts are disabled
Summary: Don't show "Search for 'something' with" in context menu if Web shortcuts are...
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: copy-paste (show other bugs)
Version: 19.12.1
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-02 08:29 UTC by Matej Mrenica
Modified: 2020-04-29 02:27 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/kde/konsole/commit/76776c6b59f4adec7ba49b4da8b7fa6f1c8ec49a
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2020-02-02 08:29:35 UTC 
SUMMARY
...otherwise this option doesn't do anything. Either add a warning that one needs to enable Web shortcuts or grey this option out.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66
Qt Version: 5.14.1
Comment 1 Kurt Hindenburg 2020-03-28 15:45:14 UTC 
I agree; I'll have to see how to determine if web shortcuts are disabled in system  settings.
Comment 2 Ahmad Samir 2020-03-28 15:59:32 UTC 
IIUC, that would be this https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/ikwsopts.cpp#n324
Comment 3 Kurt Hindenburg 2020-03-28 16:33:37 UTC 
(In reply to Ahmad Samir from comment #2)
> IIUC, that would be this
> https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/ikwsopts.cpp#n324

Yea, I really dislike have to readConfig for stuff like this.
Comment 4 Kurt Hindenburg 2020-04-28 15:07:08 UTC 
Git commit 1b08f3058ae7dfb59778af0a885120dd75e7bf01 by Kurt Hindenburg.
Committed on 28/04/2020 at 14:42.
Pushed by hindenburg into branch 'master'.

Do not show "Search for" if web shortcuts are disabled

Before showing menu, check System Settings to see if user has disabled
"Enable Web shortcuts".

M  +6    -0    src/SessionController.cpp

https://invent.kde.org/kde/konsole/commit/1b08f3058ae7dfb59778af0a885120dd75e7bf01
Comment 5 Kurt Hindenburg 2020-04-29 02:27:55 UTC 
Git commit 76776c6b59f4adec7ba49b4da8b7fa6f1c8ec49a by Kurt Hindenburg.
Committed on 29/04/2020 at 02:23.
Pushed by hindenburg into branch 'release/20.04'.

Do not show "Search for" if web shortcuts are disabled

Before showing menu, check System Settings to see if user has disabled
"Enable Web shortcuts".
(cherry picked from commit 1b08f3058ae7dfb59778af0a885120dd75e7bf01)

M  +6    -0    src/SessionController.cpp

https://invent.kde.org/kde/konsole/commit/76776c6b59f4adec7ba49b4da8b7fa6f1c8ec49a