Bug 417029 - Toolbar action order doesn't make sense
Summary: Toolbar action order doesn't make sense
Status: CONFIRMED
Alias: None
Product: kdevelop
Classification: Applications
Component: UI: general (show other bugs)
Version: git master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-01 16:33 UTC by David Redondo
Modified: 2021-01-19 09:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Build and Install on opposites sides (41.10 KB, image/png)
2020-02-01 16:33 UTC, David Redondo
Details
Random order of the main toolbar (48.15 KB, image/png)
2020-02-01 16:33 UTC, David Redondo
Details
After moving "Execute up" it's now the leftmost item (55.22 KB, image/png)
2020-02-01 16:35 UTC, David Redondo
Details
Moving Install has no effect (43.97 KB, image/png)
2020-02-01 16:36 UTC, David Redondo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Redondo 2020-02-01 16:33:05 UTC
Created attachment 125594 [details]
Build and Install on opposites sides

SUMMARY
The toolbar consists of multiple toolbars and the order in which the actions appear is seemingly random and changes unexpectedly when configuration is changed.

STEPS TO REPRODUCE
for example Try to add "install" next to "build"

OBSERVED RESULT
Build is on the far left, install on the far right
EXPECTED RESULT
The actions should be next to each other
SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.66
Qt Version: 5.13.2
Comment 1 David Redondo 2020-02-01 16:33:58 UTC
Created attachment 125595 [details]
Random order of the main toolbar
Comment 2 David Redondo 2020-02-01 16:35:04 UTC
Created attachment 125596 [details]
After moving "Execute up" it's now the leftmost item
Comment 3 David Redondo 2020-02-01 16:36:15 UTC
Created attachment 125597 [details]
Moving Install has no effect
Comment 4 Friedrich W. H. Kossebau 2020-02-01 17:28:53 UTC
Why looking at the screenshots I wonder for a start: is there a chance you renamed the text of the action "Install Selection" to be "Install"?

Please tell what .local/share/kxmlgui5/kdevprojectmanagerview/kdevprojectmanagerview.rc has for "project_install" (or best just show the complete file)
Comment 5 Friedrich W. H. Kossebau 2020-02-01 17:31:01 UTC
Oh, just found that moving actions from "Available actions" to "Current actions" changes the name here, so I now see e.g. just "Install" as well.
Comment 6 Friedrich W. H. Kossebau 2020-02-01 19:35:30 UTC
Okay, text change explained as for some reason the "Current actions" column only displays the "iconText" property of an action, where the "Available actions" column displays the "text" property. And those are different for e.g. the "Install selection" action.

And things are screwed up when it comes to action, because the dialog does not support groups on toolbars, and also ignores any group properties set on actions int the <Menu> section.
So we get <Action name="project_build" group="build_operations"/> vs. <Action name="project_install"/>. And actions without a group are appended, thus the order.

This needs fixing in kmlgui in some way.
Comment 7 popov895 2021-01-19 09:58:20 UTC
Yes, it would be great if the toolbars are in order.