Bug 417024 - Notification shows wrong amount of copied files when I check "Apply to all" and click on "Rename" button of owerwrite dialog
Summary: Notification shows wrong amount of copied files when I check "Apply to all" a...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: Overwrite dialog (other bugs)
Version First Reported In: 5.73.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-01 14:52 UTC by Patrick Silva
Modified: 2022-05-23 19:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screen recording (1.86 MB, video/webm)
2020-02-01 14:52 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-02-01 14:52:26 UTC
Created attachment 125591 [details]
screen recording

SUMMARY
Watch the screen recording please.
I'm pasting 4 files, all of them already present in destination, overwrite dialog appears, I check "Apply to all" and click on "Rename" button, then a notification incorrectly says "Copying (finished) - 7 files to destination".


EXPECTED RESULT
notification should show correct amount of files copied.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
also reproducible on Neon unstable edition
Comment 1 Patrick Silva 2020-08-14 20:37:15 UTC
Right. And if a single file was copied (out of 4) then the notification should say "1/1 file copied", instead of "4/4", right? (1/4 would lead to a 25% progress bar, that would be bad). So by extension skipping all files would lead to "0/0 files copied"... ?

My 2 cents as an end user:
The notification says
"Copying (Finished)
y of x files to /path/to/destination"

What means "x" here? The amount of files which the user wants to copy to destination? As an end user, I think so. But I could be mistaken.

I suppose that "y of x" indicates the proportion between the amount of files that the user wants to copy and the one effectively copied to destination. However, in my screen recording the notification confusely says

"Copying (Finished)
4 of 4 files to /path/to/destination"

despite 0 file have been copied to destination. 4 of 4 files were skipped, not copied. :)

A notification saying "Copying (Finished) 0 of 4 files to..." would be coherent
in my screen recording, because I have dragged-n-dropped 4 files and 0 was copied to destination.

If 1 file was copied, the notification should say "Copying (Finished) 1 of 4 file to..."

Personally I consider these file operations notifications annoying and sometimes confusing,
that's why I opened bug 425355 a few minutes ago.
Comment 2 Patrick Silva 2020-08-14 20:38:54 UTC
ignore my previous comment please. Wrong report.
Comment 3 Patrick Silva 2022-05-23 19:30:40 UTC
Cannot reproduce either on Arch or neon unstable.

Operating System: Arch Linux
KDE Plasma Version: 5.24.90
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4
Graphics Platform: Wayland