Bug 416864 - (Semi) Reliable, fast way to krita crash and file corruption using undo while colorize masked editing tool
Summary: (Semi) Reliable, fast way to krita crash and file corruption using undo while...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Colorize (show other bugs)
Version: 4.2.8
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 416846 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-01-28 14:48 UTC by spamdotspamy
Modified: 2020-02-07 17:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Corrupted image, you can see what I have drawn (2.04 MB, application/x-krita)
2020-01-28 14:48 UTC, spamdotspamy
Details
krita log (4.12 KB, text/plain)
2020-01-28 14:51 UTC, spamdotspamy
Details
My old test file used under windows 10 to repudce the crash/corruption (2.15 MB, application/x-krita)
2020-01-28 15:20 UTC, spamdotspamy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description spamdotspamy 2020-01-28 14:48:47 UTC
Created attachment 125488 [details]
Corrupted image, you can see what I have drawn

SUMMARY

I can reliable and fast corrupt files in a manner as the attached file by doing the following:

STEPS TO REPRODUCE
1. draw a few lines to use the colorize masked editing tool. I drew a cross and a rectangle within each other (see attached file)
2. use the coloring tool to color all rectangles. Color the outside in a transparent fashion
3. While the tool is calculating undo one of your changes
4. Krita will crash
5. The file will be corrupted
6. The file can't open under other system (tested on linux)

OBSERVED RESULT

File corrupt, artist sad

EXPECTED RESULT

No crash in Krita and most importantly no file corruption

SOFTWARE/OS VERSIONS
Windows: 7

ADDITIONAL INFORMATION
See the attachment for a corrupted file and a way to repoduce
Comment 1 spamdotspamy 2020-01-28 14:51:15 UTC
Created attachment 125489 [details]
krita log

Part of my log so you can see what is causing this
Comment 2 spamdotspamy 2020-01-28 14:51:54 UTC
This makes bug 416846 obsolete
Comment 3 Halla Rempt 2020-01-28 14:53:47 UTC
*** Bug 416846 has been marked as a duplicate of this bug. ***
Comment 4 spamdotspamy 2020-01-28 15:07:24 UTC
Very important addendum: you have to click on "Edit key strokes" between step 3. and step 4!

This might cause the crash on its own. Without it you won't always crash.
Comment 5 spamdotspamy 2020-01-28 15:18:52 UTC
Friend of mine can reproduce under Windows 10 Krita 4.2.8 but it is less reliable

STEPS TO REPRODUCE
1. draw a few lines to use the colorize masked editing tool. I drew a cross and a rectangle within each other (see attached file)
2. use the coloring tool to color all rectangles. Color the outside in a transparent fashion
3. While the tool is calculating undo one of your changes
4. While the tool is calculating click on "Edit key strokes" 
4.b) undo/redo changes if no crash. This might be done after the calculation is done
5. Krita will crash
6. The file will be corrupted
7. The file can't open under other system (tested on windows 7)


ADDITIONAL INFORMATION
It has something to do with the "colorize masked editing tool","Edit key strokes" and the "undo" & "redo"

I add the corrupted file as "test_windows10.kra"
Comment 6 spamdotspamy 2020-01-28 15:20:21 UTC
Created attachment 125490 [details]
My old test file used under windows 10 to repudce the crash/corruption
Comment 7 Ahab Greybeard 2020-01-29 16:49:58 UTC
I can't reproduce this with the Jan 28th 4.3.0 prealpha appimage git(049dd11) and both the provided test .kra files open ok and behave well.

I can't reproduce this with the 4.2.8 appimage but both the provided test .kra files cause a vanishment crash when opened.

I can't reproduce this with the Jan 20th 4.3.0 prealpha Windows standalone .zip package git (07888a2) and both the provided test .kra files open ok and behave well.

I can't reproduce this with the 4.2.8 Windows standalone .zip package  but both the provided test .kra files cause a vanishment crash when opened.

My inability to reproduce the crash may be due to not replicating the process exactly as you did,

Can you test this with the latest Nightly Build from https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/lastSuccessfulBuild/artifact/krita-nightly-x64-v4.3.0-prealpha-1071-g065745731c.zip and see if still happens?
Comment 8 spamdotspamy 2020-02-07 17:22:32 UTC
I did the test with the latest Krita Plus version.

The problem seems to be solved!
Apparently the bug is no longer triggerable!
The corrupted files are readable again.
The corrupted files appear to be in order!

Please note: the biggest problem was to understand that there is a Krita Plus version. I strongly recommend to promote this version more / better.