Bug 416781 - Search title shows encoded search term
Summary: Search title shows encoded search term
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.17.5
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-26 09:56 UTC by Schlaefer
Modified: 2020-02-07 15:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.1


Attachments
Screenshot of issue (80.55 KB, image/png)
2020-01-26 09:56 UTC, Schlaefer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Schlaefer 2020-01-26 09:56:41 UTC
Created attachment 125424 [details]
Screenshot of issue

SUMMARY

The search title "Search: <search term>" shows <search term> with URL encoded special chars.

STEPS TO REPRODUCE
1. Search for the string with special characters: "foo & bar"

OBSERVED RESULT

Search title on top of search results reads: "Search: foo &amp; bar"

EXPECTED RESULT

Search title on top of search should show: "Search: foo & bar"

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Comment 1 Nate Graham 2020-01-31 22:45:33 UTC
Patch: https://phabricator.kde.org/D27079
Comment 2 Nate Graham 2020-02-07 15:14:02 UTC
Git commit 9bf3f942d329dbff120f98cd12cefb281b21eddc by Nate Graham.
Committed on 07/02/2020 at 15:13.
Pushed by ngraham into branch 'Plasma/5.18'.

Don't escape search text in search page title

Summary:
Doing so makes the title display look ugly and generated a bug report. Instead of escaping
HTML entities, this patch just removes them.
FIXED-IN: 5.18.0

Test Plan:
Searching still works

Search terms with HTML-unsafe characters in them no longer look ugly in the title:

{F8070324, size=full}

Reviewers: #vdg, #discover_software_store, apol

Reviewed By: #discover_software_store, apol

Subscribers: plasma-devel, apol

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27079

M  +5    -10   discover/qml/ApplicationsListPage.qml

https://commits.kde.org/discover/9bf3f942d329dbff120f98cd12cefb281b21eddc