Bug 416718 - MobyGames data source improvements
Summary: MobyGames data source improvements
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: 3.2.3
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-25 00:41 UTC by Robby Stephenson
Modified: 2020-01-26 02:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 3.3


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robby Stephenson 2020-01-25 00:41:08 UTC
Error messages should be properly handled and shown to the user.

Configuration option for image sizes should be added.

Entry updates and general searching should be able to include platform.
Comment 1 Robby Stephenson 2020-01-25 01:13:12 UTC
Git commit 9b5a9d535336d19075c7d751523686a20ec02a99 by Robby Stephenson.
Committed on 25/01/2020 at 00:45.
Pushed by rstephenson into branch 'master'.

mobygamesfetcher - check for error response and pass to user

M  +10   -0    src/fetch/mobygamesfetcher.cpp

https://commits.kde.org/tellico/9b5a9d535336d19075c7d751523686a20ec02a99
Comment 2 Robby Stephenson 2020-01-25 01:13:12 UTC
Git commit 2cf8aa6525ca4a2a8ad5c63ed70b626380129b5f by Robby Stephenson.
Committed on 25/01/2020 at 01:11.
Pushed by rstephenson into branch 'master'.

mobygamesfetcher: allow user selection of image size

Covers are apparently grouped by country. Take the first one that has a
"Front Cover" indication, falling back to "Media" if not found.

Small images are thumbnails, large images are otherwise.

M  +57   -9    src/fetch/mobygamesfetcher.cpp
M  +12   -0    src/fetch/mobygamesfetcher.h
M  +1    -1    src/tests/mobygamesfetchertest.cpp

https://commits.kde.org/tellico/2cf8aa6525ca4a2a8ad5c63ed70b626380129b5f
Comment 3 Robby Stephenson 2020-01-25 16:59:04 UTC
Git commit d41087493cb06c3581858f37838e6d978138414e by Robby Stephenson.
Committed on 25/01/2020 at 16:57.
Pushed by rstephenson into branch 'master'.

MobyGamesFetcher - cache platform name, add raw query, improve timer

Use the platform name normalization and cache the mapping from MobyGames
id to name. Improve the idle timer to honor the API request limit of
once per second. Add a Raw query to allow entry updates to use a
platform name to avoid additional API hits.

M  +67   -19   src/fetch/mobygamesfetcher.cpp
M  +10   -0    src/fetch/mobygamesfetcher.h
M  +33   -0    src/tests/mobygamesfetchertest.cpp
M  +1    -0    src/tests/mobygamesfetchertest.h

https://commits.kde.org/tellico/d41087493cb06c3581858f37838e6d978138414e
Comment 4 Robby Stephenson 2020-01-25 19:16:21 UTC
Git commit b3dd4e718c178f8455b7cc9dc87429addfa8249b by Robby Stephenson.
Committed on 25/01/2020 at 19:15.
Pushed by rstephenson into branch 'master'.

Improve MobyGames update request to use platform name, if present

M  +5    -1    ChangeLog
M  +38   -10   src/fetch/mobygamesfetcher.cpp
M  +6    -3    src/fetch/mobygamesfetcher.h
M  +57   -2    src/tests/mobygamesfetchertest.cpp
M  +5    -1    src/tests/mobygamesfetchertest.h

https://commits.kde.org/tellico/b3dd4e718c178f8455b7cc9dc87429addfa8249b
Comment 5 Robby Stephenson 2020-01-26 02:19:04 UTC
Git commit f7abcac1aa1060294ae2937ea3338d551aa9e7e1 by Robby Stephenson.
Committed on 26/01/2020 at 02:16.
Pushed by rstephenson into branch 'master'.

Add Keyword search for MobyGames data source

For a Keyword search, if the platform name is included in the search
string, it is used to narrow down the search. The name must match
the existing platform name exactly. The search strign itself is still
just a title search.
FIXED-IN: 3.3

M  +32   -4    src/fetch/mobygamesfetcher.cpp
M  +1    -0    src/fetch/mobygamesfetcher.h
M  +30   -0    src/tests/mobygamesfetchertest.cpp
M  +1    -0    src/tests/mobygamesfetchertest.h

https://commits.kde.org/tellico/f7abcac1aa1060294ae2937ea3338d551aa9e7e1