Bug 416697 - Last move not counted in Freecell
Summary: Last move not counted in Freecell
Status: RESOLVED FIXED
Alias: None
Product: kpat
Classification: Applications
Component: solver (other bugs)
Version First Reported In: 3.6
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-24 15:33 UTC by Pedro Lino
Modified: 2021-12-09 16:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Lino 2020-01-24 15:33:55 UTC
SUMMARY
The last move is not counted

STEPS TO REPRODUCE
1. Play game 9998 in whatever order you prefer and leave the King and Queen of Clubs (second column) for the last play
2. Notice the current number of plays and move the King to another column or freecell
3. Solver will move Queen and King to the foundation (two moves) 

OBSERVED RESULT
Only one move is counted

EXPECTED RESULT
Two moves are counted

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Ubuntu 18.04.3 LTS
(available in About System)
KDE Plasma Version: running on Gnome 3.28.2
KDE Frameworks Version: KDE Frameworks 5.44.0
Qt Version: Qt 5.9.5 (built against 5.9.5)

ADDITIONAL INFORMATION
This is probably related to previously reported bug https://bugs.kde.org/show_bug.cgi?id=409080
Comment 1 Albert Astals Cid 2020-01-25 00:30:35 UTC
This seems to be working fine for me.

Could you try with the verison from flathub?

https://flathub.org/apps/details/org.kde.kpat

In case you're running an old version of things and we already fixed that?
Comment 2 Pedro Lino 2020-01-26 23:03:22 UTC
(In reply to Albert Astals Cid from comment #1)
> This seems to be working fine for me.
> 
> Could you try with the version from flathub?
> 
> https://flathub.org/apps/details/org.kde.kpat
> 
> In case you're running an old version of things and we already fixed that?

I installed the version from flathub (19.12.1) and the problem still occurs (although all other issues I reported previously are solved in this version. I will report and close those issues asap)
The reason the very old version 3.6 is installed is because that is the one still available on the Ubuntu Software "store" (without snap or flatpak) for Ubuntu 18.04

Describing the steps: if I am at play 58 and there are two cards left (King of Clubs on top of Queen of Clubs), moving the King (to another column or freecell) counts as move 59 and then moving the Queen and the King to the foundation should be moves 60 and 61 but the counter stops at 60
Comment 3 Albert Astals Cid 2020-01-26 23:50:39 UTC
Right, there's totally a problem, for example the first two aces get just counted as one movement

https://i.imgur.com/ZjsCVBk.png
Comment 4 Albert Astals Cid 2020-02-12 00:04:10 UTC
https://phabricator.kde.org/D27336
Comment 5 Albert Astals Cid 2020-02-18 20:39:20 UTC
Git commit 78ea459bc4aec653c1f6618896cbf0fbefec0ae2 by Albert Astals Cid.
Committed on 18/02/2020 at 20:39.
Pushed by aacid into branch 'master'.

Fix sometimes two moves being counted as one

Reviewers: #kde_games, fabiank

Reviewed By: fabiank

Subscribers: fabiank, piotrkakol, shlomif, yurchor, kde-games-devel

Differential Revision: https://phabricator.kde.org/D27336

M  +1    -1    dealer.cpp

https://commits.kde.org/kpat/78ea459bc4aec653c1f6618896cbf0fbefec0ae2
Comment 6 Pedro Lino 2020-04-29 23:02:31 UTC
Verified fixed in version 20.04.

Thank you!
Comment 7 Albert Astals Cid 2021-12-09 16:24:43 UTC
Git commit 31457653b42e2a97c20ebdcbedb68b0b0998a943 by Albert Astals Cid.
Committed on 18/02/2020 at 20:38.
Pushed by aacid into branch 'arcpatch-D27336'.

Fix sometimes two moves being counted as one

Reviewers: #kde_games, fabiank

Reviewed By: fabiank

Subscribers: fabiank, piotrkakol, shlomif, yurchor, kde-games-devel

Differential Revision: https://phabricator.kde.org/D27336

M  +1    -1    dealer.cpp

https://invent.kde.org/games/kpat/commit/31457653b42e2a97c20ebdcbedb68b0b0998a943