Bug 416695 - Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window
Summary: Chord keyboard shortcuts that begin with Alt+D all open the desktop settings ...
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop Containment (show other bugs)
Version: 5.17.90
Platform: Kubuntu Linux
: NOR major
Target Milestone: 1.0
Assignee: Marco Martin
Keywords: regression
Depends on:
Reported: 2020-01-24 14:50 UTC by chimak111
Modified: 2020-02-14 12:17 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.1

Image of the context menu in Plasma 5.17.90 when right-clicking on the desktop in Desktop Layout (24.02 KB, image/png)
2020-01-24 14:50 UTC, chimak111

Note You need to log in before you can comment on or make changes to this bug.
Description chimak111 2020-01-24 14:50:10 UTC
Created attachment 125370 [details]
Image of the context menu in Plasma 5.17.90 when right-clicking on the desktop in Desktop Layout

The shortcuts provided are confusing; some don't match the description

1. Right-click on the desktop in "Layout:Desktop", **not** in Folder View
2. Note the descriptions and the associated shortcuts (image provided)
3. Use the shortcuts **without** first right-clicking on the Desktop

All the shortcuts beginning with Alt+D just open Desktop Settings instead of what the text describes.

The shortcut for "Add Widgets..." Alt+D,A should be just Alt+A which works to open "Add Widgets..."

The keyboard shortcuts should match the textual descriptions

Linux/KDE Plasma: Kubuntu 20.04
(available in About System)
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.12.5

Comment 1 Christoph Feck 2020-02-13 20:02:26 UTC
These shortcuts used to work in previous versions, and it was intended that they all start with Alt+D.
Comment 2 David Edmundson 2020-02-13 22:23:38 UTC
22:21:01.519 QShortcutMap::createNewSequences createNewSequences(QKeyEvent(ShortcutOverride, Key_D, AltModifier, text="d"), ignoredModifiers=QFlags<Qt::KeyboardModifier>(NoModifier)), possibleKeys=(QKeySequence("Alt+D"))
22:21:01.519 QShortcutMap::find Possible shortcut key sequences: QVector(QKeySequence("Alt+D"))
22:21:01.519 QShortcutMap::find Found better match ( QVector(QKeySequence("Alt+D")) ), clearing key sequence list
22:21:01.519 QShortcutMap::find Added ok key sequence QVector(QKeySequence("Alt+D"))
22:21:01.520 QShortcutMap::find Returning shortcut match ==  2
22:21:01.520 QShortcutMap::nextState QShortcutMap::nextState(QKeyEvent(ShortcutOverride, Key_D, AltModifier, text="d")) = 2     (exact match)
22:21:01.520 QShortcutMap::dispatchEvent QShortcutMap::dispatchEvent(): Sending QShortcutEvent(""Alt+D"", -167, false) to object(ToolButton_QMLTYPE_21_QML_209(0x557fb03cf060))

some toolbutton somewhere has the shortcut "alt+d", possibly through the added accelerators
Comment 3 David Edmundson 2020-02-13 22:25:52 UTC
Wow, it's the invisible toolbox.

A button in there has some text that gets a kirigami acclerator applied
Comment 4 David Edmundson 2020-02-14 12:17:41 UTC
Git commit 7a48de1efa224e616d9f24f1fa1e4cdab0bce196 by David Edmundson.
Committed on 14/02/2020 at 12:17.
Pushed by davidedmundson into branch 'Plasma/5.18'.

Set toolbox to invisble when it's hidden

opacity was bound to editMode, but this did not affect visibility or

Not only is this somewhat wasteful, enabled is very important as
otherwise shortcuts for buttons get intercepted to match the accelerator
applied to the internal buttons. This breaks all the multi-key shortcuts
that plasma uses as alt+d gets taken.
FIXED-IN: 5.18.1

Test Plan:
Mad gammaray skillz to find the bug

Checked alt+d, a now opens the widget explorer
Checked edit mode through the context menu still showed the toolbox

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27386

M  +1    -0    toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
M  +0    -2    toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml