Bug 416685 - Makefile invalid highlight
Summary: Makefile invalid highlight
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (other bugs)
Version First Reported In: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-24 10:34 UTC by fclushio
Modified: 2020-02-12 11:12 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/syntax-highlighting/5bd8719d46556dcb755e54e4637061678c4bc7da
Version Fixed/Implemented In: 5.68.0
Sentry Crash Report:

Attachments
Red highlight below (3.88 KB, image/png)
2020-01-24 10:34 UTC, fclushio 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description fclushio 2020-01-24 10:34:16 UTC 
Created attachment 125362 [details]
Red highlight below

VAR := $(ANOTHER_VAR:%=%+1)

Such construction is highlighted as invalid though it is allowed.

https://www.gnu.org/savannah-checkouts/gnu/make/manual/html_node/Text-Functions.html

$(var:pattern=replacement)

Linux u18p 4.15.0-74-generic #84-Ubuntu 
Qt Creator 4.5.2
Comment 1 Christoph Cullmann 2020-02-09 11:33:12 UTC 
Git commit 5bd8719d46556dcb755e54e4637061678c4bc7da by Christoph Cullmann, on behalf of Nibaldo González.
Committed on 09/02/2020 at 11:32.
Pushed by cullmann into branch 'master'.

Makefile highlight: add substitutions

Summary:

Add substitutions:
```
$(var:pattern=replacement)
```

**Source:** https://www.gnu.org/savannah-checkouts/gnu/make/manual/html_node/Text-Functions.html

Reviewers: #framework_syntax_highlighting, dhaumann, cullmann

Reviewed By: #framework_syntax_highlighting, cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D27009

M  +8    -0    autotests/folding/Makefile.fold
M  +8    -0    autotests/html/Makefile.html
M  +8    -0    autotests/input/Makefile
M  +8    -0    autotests/reference/Makefile.ref
M  +13   -2    data/syntax/makefile.xml

https://commits.kde.org/syntax-highlighting/5bd8719d46556dcb755e54e4637061678c4bc7da