Bug 416640 - Shadowless task switcher on Wayland
Summary: Shadowless task switcher on Wayland
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: wayland-generic (show other bugs)
Version: 5.17.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 416641 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-01-23 10:58 UTC by Patrick Silva
Modified: 2020-06-11 14:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.72.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-01-23 10:58:03 UTC
SUMMARY
Task switcher (I use Large Icons) is shadowless on Wayland session.

Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Comment 1 Vlad Zahorodnii 2020-01-23 11:56:57 UTC
We did a relatively big change in 5.18 to port internal clients away from wayland. There were many reasons to do it. Unfortunately things such as shadows were quite platform specific. Breeze style plugin could upload shadow tiles to KWin only via our proprietary X11 and Wayland protocols.

Fortunately, shadows will be back in KDE Plasma 5.19. The bad news is that we didn't manage to get all relevant shadows API changes in KWindowSystem in KF 5.66. :/
Comment 2 Nate Graham 2020-01-23 19:49:51 UTC
So is there anything to be done for this bug, or should we close it?
Comment 3 Nate Graham 2020-01-23 19:49:51 UTC
*** Bug 416641 has been marked as a duplicate of this bug. ***
Comment 4 Vlad Zahorodnii 2020-01-25 00:06:14 UTC
(In reply to Nate Graham from comment #2)
> So is there anything to be done for this bug
No, I don't think so.
Comment 5 Patrick Silva 2020-05-24 18:28:15 UTC
(In reply to Vlad Zahorodnii from comment #1)
> Fortunately, shadows will be back in KDE Plasma 5.19. 
Plasma 5.19 beta was released and task switcher is still shadowless. :(
Comment 6 Vlad Zahorodnii 2020-06-11 10:19:00 UTC
Git commit 4ddf0d9944176e96b195f008ef99448feab882ef by Vlad Zahorodnii.
Committed on 11/06/2020 at 10:18.
Pushed by vladz into branch 'master'.

[Dialog Shadows] Port to KWindowSystem shadows API

Summary: BUG: 416640

Test Plan: Run `qmlscene tests/dialog.qml`

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T12496

Differential Revision: https://phabricator.kde.org/D26503

M  +92   -493  src/plasmaquick/dialogshadows.cpp
M  +3    -3    src/plasmaquick/dialogshadows_p.h
M  +0    -43   src/plasmaquick/waylandintegration.cpp
M  +0    -6    src/plasmaquick/waylandintegration_p.h

https://invent.kde.org/frameworks/plasma-framework/commit/4ddf0d9944176e96b195f008ef99448feab882ef
Comment 7 Vlad Zahorodnii 2020-06-11 10:31:43 UTC
@Patrick The task switcher will have shadows when you update KF to 5.71, which is going to be released the next month.
Comment 8 Patrick Silva 2020-06-11 11:02:11 UTC
(In reply to Vlad Zahorodnii from comment #7)
> @Patrick The task switcher will have shadows when you update KF to 5.71,
> which is going to be released the next month.

frameworks 5.71 will be released on next Saturday.
Or did you mean frameworks 5.72?
Comment 9 Vlad Zahorodnii 2020-06-11 14:01:21 UTC
(In reply to Patrick Silva from comment #8)
> (In reply to Vlad Zahorodnii from comment #7)
> > @Patrick The task switcher will have shadows when you update KF to 5.71,
> > which is going to be released the next month.
> 
> frameworks 5.71 will be released on next Saturday.
> Or did you mean frameworks 5.72?

Yes, my bad. I meant 5.72.