Bug 416585 - libs-image-kis_processings_test (Failed)
Summary: libs-image-kis_processings_test (Failed)
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Unittests (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-22 14:43 UTC by Halla Rempt
Modified: 2020-08-12 17:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2020-01-22 14:43:15 UTC
166/285 Testing: libs-image-kis_processings_test
166/285 Test: libs-image-kis_processings_test
Command: "/home/boud/dev/b-krita/libs/image/tests/kis_processings_test"
Directory: /home/boud/dev/b-krita/libs/image/tests
"libs-image-kis_processings_test" start time: Jan 22 15:10 CET
Output:
----------------------------------------------------------
********* Start testing of KisProcessingsTest *********
Config: Using QtTest library 5.13.2, Qt 5.13.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0)
PASS   : KisProcessingsTest::initTestCase()
QWARN  : KisProcessingsTest::testCropVisitor() KoColor debug runtime checks are active.
QDEBUG : KisProcessingsTest::testCropVisitor()  Different at QPoint(350,120) source 243 247 214 3 dest 243 247 213 13 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testCropVisitor()  Different at QPoint(350,120) source 243 247 214 3 dest 243 247 213 13 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testCropVisitor()  Different at QPoint(123,120) source 248 248 210 0 dest 248 248 210 3 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testCropVisitor()  Different at QPoint(123,120) source 248 248 210 0 dest 248 248 210 3 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
FAIL!  : KisProcessingsTest::testCropVisitor() 'checkLayersInitial(image)' returned FALSE. ()
   Loc: [/home/boud/dev/krita/libs/image/tests/kis_processings_test.cpp(50)]
QDEBUG : KisProcessingsTest::testTransformVisitorScale()  Different at QPoint(350,120) source 243 247 214 3 dest 243 247 213 13 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testTransformVisitorScale()  Different at QPoint(350,120) source 243 247 214 3 dest 243 247 213 13 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testTransformVisitorScale()  Different at QPoint(123,120) source 248 248 210 0 dest 248 248 210 3 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testTransformVisitorScale()  Different at QPoint(123,120) source 248 248 210 0 dest 248 248 210 3 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
FAIL!  : KisProcessingsTest::testTransformVisitorScale() 'checkLayersInitial(image)' returned FALSE. ()
   Loc: [/home/boud/dev/krita/libs/image/tests/kis_processings_test.cpp(50)]
QDEBUG : KisProcessingsTest::testTransformVisitorScaleRotate()  Different at QPoint(350,120) source 243 247 214 3 dest 243 247 213 13 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testTransformVisitorScaleRotate()  Different at QPoint(350,120) source 243 247 214 3 dest 243 247 213 13 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testTransformVisitorScaleRotate()  Different at QPoint(123,120) source 248 248 210 0 dest 248 248 210 3 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
QDEBUG : KisProcessingsTest::testTransformVisitorScaleRotate()  Different at QPoint(123,120) source 248 248 210 0 dest 248 248 210 3 fuzzy 1 fuzzyAlpha 1 ( 1 of 0 allowed )
FAIL!  : KisProcessingsTest::testTransformVisitorScaleRotate() 'checkLayersInitial(image)' returned FALSE. ()
   Loc: [/home/boud/dev/krita/libs/image/tests/kis_processings_test.cpp(50)]
PASS   : KisProcessingsTest::cleanupTestCase()
Totals: 2 passed, 3 failed, 0 skipped, 0 blacklisted, 1579ms
********* Finished testing of KisProcessingsTest *********
<end of output>
Test time =   2.33 sec
----------------------------------------------------------
Test Failed.
"libs-image-kis_processings_test" end time: Jan 22 15:10 CET
"libs-image-kis_processings_test" time elapsed: 00:00:02
----------------------------------------------------------
Comment 1 Dmitry Kazakov 2020-08-11 11:43:59 UTC
Git commit ef3d8f631da46ee8393241535168406c6ae345f8 by Dmitry Kazakov.
Committed on 11/08/2020 at 11:43.
Pushed by dkazakov into branch 'krita/4.3'.

Fix KisProcessingsTest failure caused by two significant changes in Krita

1) Blur filter has changed the meaning of 'strength' option. It is
   not very good backward-compatibility wise, but we have already
   released this version of a filter :(

2) Nearest Neighbour filtration algorithm has changed after a
   refactoring half a year ago

M  +1    -6    libs/image/tests/CMakeLists.txt
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_blur1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_blur1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_clone1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_clone1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_paint1_paintDevice.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_paint1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_root_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_root_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_blur1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_blur1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_clone1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_clone1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_paint1_paintDevice.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_paint1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_root_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_root_projection.png
M  +9    -0    sdk/tests/qimage_based_test.h

https://invent.kde.org/graphics/krita/commit/ef3d8f631da46ee8393241535168406c6ae345f8
Comment 2 Dmitry Kazakov 2020-08-12 17:54:01 UTC
Git commit 1a7f737b84fb888b112e12c388a1b895ae324d26 by Dmitry Kazakov.
Committed on 12/08/2020 at 17:52.
Pushed by dkazakov into branch 'master'.

Fix KisProcessingsTest failure caused by two significant changes in Krita

1) Blur filter has changed the meaning of 'strength' option. It is
   not very good backward-compatibility wise, but we have already
   released this version of a filter :(

2) Nearest Neighbour filtration algorithm has changed after a
   refactoring half a year ago

# Conflicts:
#	sdk/tests/qimage_based_test.h

M  +1    -6    libs/image/tests/CMakeLists.txt
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_blur1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_blur1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_clone1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_clone1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_paint1_paintDevice.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_paint1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_root_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale/transform_scale_root_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_blur1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_blur1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_clone1_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_clone1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_paint1_paintDevice.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_paint1_projection.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_root_original.png
M  +-    --    libs/image/tests/data/processings/transform_scale_rotate/transform_scale_rotate_root_projection.png
M  +8    -0    sdk/tests/qimage_based_test.h

https://invent.kde.org/graphics/krita/commit/1a7f737b84fb888b112e12c388a1b895ae324d26