Bug 416578 - Remove Lock Widgets from "Configure Contextual Menu Plugin"
Summary: Remove Lock Widgets from "Configure Contextual Menu Plugin"
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop Containment (show other bugs)
Version: 5.17.90
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-22 14:32 UTC by chimak111
Modified: 2020-01-30 15:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0
Sentry Crash Report:


Attachments
Image showing redundant "Lock Widgets" entry (56.12 KB, image/jpeg)
2020-01-22 14:32 UTC, chimak111
Details

Note You need to log in before you can comment on or make changes to this bug.
Description chimak111 2020-01-22 14:32:43 UTC
Created attachment 125300 [details]
Image showing redundant "Lock Widgets" entry

SUMMARY
The entry titled "Lock Widgets" can be removed from "Configure Contextual Menu Plugin".

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 19.10 
KDE Plasma Version: 5.17.90 
KDE Frameworks Version: 5.66.0 
Qt Version: 5.12.4
Comment 1 Nate Graham 2020-01-22 16:47:32 UTC
Submitted a patch to fix this: https://phabricator.kde.org/D26845
Comment 2 Nate Graham 2020-01-30 15:53:52 UTC
Git commit 66940389d66b1c9d04a058cf3632bb1c0b33171a by Nate Graham.
Committed on 30/01/2020 at 15:53.
Pushed by ngraham into branch 'Plasma/5.18'.

[context menu] Remove last traces of "Lock Widgets" action from UI

Summary:
In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the
context meny configuration dialog though, and it's still referenced in some of the
context menu building code.

This patch removes it from those places
FIXED-IN: 5.18.0

Test Plan:
Context menu still looks the same on the desktop and panel, both in and out of edit mode
The action no longer shows up in the configuration UI.

Please review carefully as this code is fairly unfamiliar to me.

Reviewers: mart, #plasma

Reviewed By: mart, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26845

M  +4    -10   containmentactions/contextmenu/menu.cpp

https://commits.kde.org/plasma-workspace/66940389d66b1c9d04a058cf3632bb1c0b33171a