Bug 416411 - Show Desktop/Minimize All doesn't respect icon theme
Summary: Show Desktop/Minimize All doesn't respect icon theme
Status: RESOLVED INTENTIONAL
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.17.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-18 08:59 UTC by Nick Stefanov
Modified: 2020-01-19 23:06 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Stefanov 2020-01-18 08:59:24 UTC
SUMMARY
After recent updates Show Desktop/Minimize All doesn't respect icon theme. I have a backup with 5.17.4 and there isn't a problem:
https://i.imgur.com/h1rDA1T.png
https://i.imgur.com/jMELQ7O.png

When I upgrade to 5.17.5 the icon changes itself to monochrome and there's no way to change it:
https://i.imgur.com/1dvdZnB.png
https://i.imgur.com/bmdN8bP.png

I replaced every single user-desktop.svg icon in my system to no avail. I took the new user-desktop.svg from /breeze/places/32 and replaced it in 22 & 16 to no avail. I downloaded various different icon themes, tried breeze-dark - there's no change. I upgraded to 5.17.9 to no avail. I deleted every single user-desktop.svg to no avail. I changed the icon theme and uninstalled breeze and breeze icons completely - the icon is still the same. Where is it? Where is the icon for this widgets and why it doesn't change?

This monochrome icon is represented in the widget menu also:
https://i.imgur.com/5s244OQ.png

In this menu with 5.17.4 there is a colored breeze icon from the used icon theme, not monochrome.

It's interesting the undo removal popup is the only one that respects the icon theme:
https://i.imgur.com/n94SNYd.png

Please tell me how to get a colored icon again. You'll agree this monochrome icon isn't suitable for my Plasma theme and it's looking weird like that. I'm sure it is a problem for many people that uses different themes, not just me. Thank you.

STEPS TO REPRODUCE
1. Upgrade to 5.17.5
2. 
3. 

OBSERVED RESULT
Show Desktop/Minimize All doesn't respect icon theme

EXPECTED RESULT
Show Desktop/Minimize All should respect icon theme


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Nick Stefanov 2020-01-18 09:01:15 UTC
SOFTWARE/OS VERSIONS
Arch Linux 
KDE Plasma Version: 5.17.5/5.17.9
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Comment 2 Nate Graham 2020-01-19 15:39:09 UTC
The way plasma works is that for widget icons, first it looks for an icon in the Plasma theme, then if it doesn't find one, it looks for an icon in the general icon theme.

We added an icon for this widget to the Breeze Plasma theme recently to prevent the icon from switching between monochrome and colorful styles depending on the panel height, which was a common complaint.

However this of course results in the icon from the icon theme not being used, unless you using a different Plasma theme that doesn't have this icon in it.

On one hand, you could say that it's more consistent for the monochrome icon to be shown *everywhere*, but I do see that this actually makes it less consistent in the Widget explorer. Maybe we should add a more branding-friendly icon so that will be displayed in the widget explorer.

Ideally we would not have any icons in the Plasma theme and always use icons from the icon theme. However Because the Breeze icon theme uses both monochrome and colorful versions of the same icon depending on size, if we did this, we would have no way to override which version is displayed in cases where it looks ugly.

As for this bug report, if we removed the icon from the Plasma theme, then it would revert to being colorful at larger sizes and people would complain again. So I don't think we can do that for the time being, sorry.
Comment 3 Nick Stefanov 2020-01-19 15:54:15 UTC
Thank you, this make sense but I have a favour to ask of you - please tell me how to change it for me manually for it's not suitable for my desktop. I'll be very gratefull. I replaced the icons from Breeze theme but it doesn't change nothing. Just tell me which icon to replace. Thank you :)

Btw, I advertize KDE Plasma on every suitable moment on my site. Look for yourself :)
https://software.kaminata.net/it-novini/izleze-plasma-5-18-lts-beta/
https://software.kaminata.net/it-novini/kde-plasma-idva-s-podobrena-barzina-oshte-poveche-funktsii-i-popravki/
https://software.kaminata.net/it-novini/tazi-sedmitsa-pri-kde-plasma-sledpraznichni-podaratsi/
https://software.kaminata.net/it-novini/kde-plasma-vi-dava-koledni-podaratsi/
And so on:
https://software.kaminata.net/?s=plasma

I'm a KDE emissary :)
Comment 4 Noah Davis 2020-01-19 16:38:15 UTC
open user.svg in the desktop theme and delete the monochrome desktop icons.
Comment 5 Nick Stefanov 2020-01-19 17:23:36 UTC
Thank you for helping :)

I'm not familiar with .svg format. It consists from multiple images or?

Where I have to search - /usr/share/icons/breeze/?
Comment 6 Noah Davis 2020-01-19 21:47:01 UTC
SVG is like HTML in that it's an XML based document format, but it's used for vector graphics. SVGs can contain multiple images or images outside of the canvas area (the part that you see in the file thumbnail). You can open SVGs with SVG editors like Inkscape or text editors.

The file is located at /usr/share/plasma/desktoptheme/default/icons/user.svgz. An SVGZ is a compressed SVG, but Inkscape and Kate should have no problem opening it.
Comment 7 Nick Stefanov 2020-01-19 23:06:08 UTC
Yes, yes, yes, it works!!! Thank you man! Best regards!!!