Bug 416353 - Maximize button is miscolored when maximized
Summary: Maximize button is miscolored when maximized
Status: CONFIRMED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.27.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords:
: 481084 489970 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-01-16 20:17 UTC by Matej Mrenica
Modified: 2024-09-18 16:01 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (943 bytes, image/png)
2020-01-16 20:17 UTC, Matej Mrenica
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2020-01-16 20:17:01 UTC
Created attachment 125179 [details]
Screenshot

This is Breeze Light color scheme.
Comment 1 Janet Blackquill 2020-01-16 20:47:26 UTC
(In reply to mthw0 from comment #0)
> Created attachment 125179 [details]
> Screenshot
> 
> This is Breeze Light color scheme.

Is this a native GTK+ application or something like Chrome/ium and Firefox?
Comment 2 Matej Mrenica 2020-01-16 20:59:37 UTC
Oh, I didn't say where it is from. It's gtk3-demo and/or pamac, but not firefox (also with CSDs).
Comment 3 Nate Graham 2020-01-17 20:30:33 UTC
Works fine for me with gtk3-demo when using the Breeze Light color scheme, FWIW.
Comment 4 Mariusz Libera 2020-01-21 18:31:28 UTC
Same here. Here is how it looks like in Eye of Gnome: https://imgur.com/dMjGFYa
Comment 5 Patrick Silva 2020-02-10 01:24:45 UTC
I can confirm with pamac, but not with gtk3-demo.

Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 6 Matej Mrenica 2020-02-11 14:40:44 UTC
Interesting, I still have this issue with both.
Comment 7 Gabriel Fernandes 2020-02-20 21:05:22 UTC
I can confirm this, with Gnome calc, maps and boxes
https://imgur.com/a/KMasNOH
Comment 8 Patrick Silva 2020-02-20 21:56:17 UTC
The following apps are affected on my system when their windows are maximized while I'm using breeze light color scheme and breeze-gtk3 theme:
nautilus
eye of gnome
gnome disks
gedit
pamac
gnome boxes
gnome calculator
gnome software
evince pdf viewer
2048 (game)
dino XMPP (Jabber) chat client 
pulse effects
celluloid video player
lollypop music player
gnome music

Operating System: Arch Linux 
KDE Plasma Version: 5.18.1
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 9 Mariusz Libera 2021-02-16 18:50:28 UTC
I'm no longer experiencing this bug. I think I fixed it at some point by deleting old config files ~/.config/gtk-3.0 so you may retry with a fresh user profile.
Comment 10 Matej Mrenica 2021-05-14 11:53:13 UTC
(In reply to Mariusz Libera from comment #9)
> I'm no longer experiencing this bug. I think I fixed it at some point by
> deleting old config files ~/.config/gtk-3.0 so you may retry with a fresh
> user profile.

Still happens, deleted ~/.config/gtk-3.0 multiple times.
Comment 11 david 2023-09-24 19:13:49 UTC
I think I found the problem. In the gtk-3.0/gtk.css moving ".maximized .titlebar button.titlebutton.maximize" from the chromium section (near lines 4438) to the .maximized maximize section (near lines 4189) button fixes it for me. Now I'm not sure where that is in the source code.
Comment 13 Nate Graham 2023-09-25 20:08:40 UTC
But wouldn't that only fix the issue in Chromium and Electron-based CSD apps, and not all the apps listed in this bug report?
Comment 14 david 2023-09-26 22:28:44 UTC
(In reply to Nate Graham from comment #12)
> Here, maybe?
> https://invent.kde.org/plasma/breeze-gtk/-/blob/master/src/gtk3/applications/
> _chromium.scss?ref_type=heads#L112
Yes, and It should go somewhere here https://invent.kde.org/plasma/breeze-gtk/-/blob/master/src/gtk3/widgets/_window_decorations.scss?ref_type=heads#L186

(In reply to Nate Graham from comment #13)
> But wouldn't that only fix the issue in Chromium and Electron-based CSD
> apps, and not all the apps listed in this bug report?

No, the part that has to be moved is only the '.maximized .titlebar {', so the full thing would be '.maximized .titlebar button.titlebutton.maximize', I tested it with lutris  and it solves the issue for me. Note that the bug is not present when window_decorations.css is used (from kwin theme).

STEPS TO REPRODUCE
1. Remove window_decorations.css
2. Open gtk3 program
3. For more dramatic effect change you color scheme (from light to dark or vice versa)
Comment 15 Nate Graham 2023-09-28 18:25:37 UTC
Ok cool. Wanna submit a merge request for this?
Comment 16 david 2023-10-03 19:10:48 UTC
(In reply to Nate Graham from comment #15)
> Ok cool. Wanna submit a merge request for this?

I'm new to scss
Comment 17 david 2023-10-03 19:23:54 UTC
(In reply to Nate Graham from comment #15)
> Ok cool. Wanna submit a merge request for this?

I'm new to scss and I don't know if there is a nice way to just insert the ".titlebar button.titlebutton" to the https://invent.kde.org/plasma/breeze-gtk/-/blob/master/src/gtk3/widgets/_window_decorations.scss#L187 but without the "dialog" and "window" at the beginning (from line 68).
Comment 18 cwo 2024-09-18 14:36:43 UTC
*** Bug 481084 has been marked as a duplicate of this bug. ***
Comment 19 cwo 2024-09-18 16:01:20 UTC
*** Bug 489970 has been marked as a duplicate of this bug. ***