Bug 416352 - Changing height in Resize Canvas gives wrong offset values
Summary: Changing height in Resize Canvas gives wrong offset values
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-16 20:08 UTC by M
Modified: 2020-01-28 09:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description M 2020-01-16 20:08:24 UTC
SUMMARY
Changing the height of the canvas and then using the anchor buttons in Image > Resize Canvas seems to result in wrong offset values on the Y axis.

STEPS TO REPRODUCE
1. Create a new document of any size
2. Open Image > Resize Canvas
3. Modify the canvas height, click the different anchor buttons and check the offset above

OBSERVED RESULT
A constant Y offset value is incorrectly added with the button order from left to right.

EXPECTED RESULT
Correct canvas alignment corresponding to the buttons.

SOFTWARE/OS VERSIONS
This issue only seems to be present in master and the Next AppImage (tested git 168d3a1), I could not reproduce it in 4.2.8 (from distro repo).
Comment 1 M 2020-01-16 20:26:22 UTC
I forgot to state that changing the height input alone already causes an incorrect vertical offset, without the anchor buttons.
Comment 2 vanyossi 2020-01-17 05:46:36 UTC
Git commit 510e56baaad81d7d2b270296f0a91ab27d24b299 by Ivan Yossi.
Committed on 17/01/2020 at 05:45.
Pushed by ivany into branch 'master'.

Fix canvas offset calculation

M  +1    -1    plugins/extensions/imagesize/dlg_canvassize.cc

https://invent.kde.org/kde/krita/commit/510e56baaad81d7d2b270296f0a91ab27d24b299
Comment 3 Halla Rempt 2020-01-28 09:50:29 UTC
Git commit ff4143723cd0d2a24d0a21ee302880b14bacca05 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 28/01/2020 at 09:12.
Pushed by rempt into branch 'krita/4.2'.

Fix canvas offset calculation
(cherry picked from commit 510e56baaad81d7d2b270296f0a91ab27d24b299)

M  +2    -1    plugins/extensions/imagesize/dlg_canvassize.cc

https://invent.kde.org/kde/krita/commit/ff4143723cd0d2a24d0a21ee302880b14bacca05