Bug 416343 - Hard dependency on GTK 2/3
Summary: Hard dependency on GTK 2/3
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_style (show other bugs)
Version: 5.17.90
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Mikhail Zolotukhin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-16 16:14 UTC by Fabian Vogt
Modified: 2020-01-22 18:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2020-01-16 16:14:07 UTC
With the KCM from kde-gtk-config, if the gtk(3)_preview binary was not there, the preview button was not shown.

Now that the KCM got rewritten/moved, the button is shown nevertheless.
Comment 1 Mikhail Zolotukhin 2020-01-22 18:29:31 UTC
Git commit 74f7e06445ff44bcc104800ba444c4279a286bd3 by Mikhail Zolotukhin.
Committed on 22/01/2020 at 18:27.
Pushed by gikari into branch 'Plasma/5.18'.

[App Style KCM] Hide preview buttons, if previewers are not found

Summary:
FIXED-IN: 5.18.0

Test Plan:
# Open GTK page of Application Style KCM, the preview buttons should be present
# Delete `usr/lib/libexec/gtk_preview` file or rename it to something else
# Reopen GTK page of KCM - the GTK2 preview button should disappear
# Delete `usr/lib/libexec/gtk3_preview` file or rename it to something else
# Reopen GTK page of KCM - the GTK3 preview button should disappear too
# Bring back the deleted/renamed files
# Reopen KCM, the buttons should be present

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26770

M  +2    -0    kcms/style/CMakeLists.txt
M  +11   -0    kcms/style/gtkpage.cpp
M  +3    -0    kcms/style/gtkpage.h
M  +2    -0    kcms/style/package/contents/ui/GtkStylePage.qml

https://commits.kde.org/plasma-desktop/74f7e06445ff44bcc104800ba444c4279a286bd3