Bug 416244 - Kwin wayland incorrect window decorations when GTK app changes the default titlebar buttons
Summary: Kwin wayland incorrect window decorations when GTK app changes the default ti...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.17.5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-14 12:11 UTC by Tom B
Modified: 2020-02-14 20:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of problem (511.40 KB, image/png)
2020-01-14 12:11 UTC, Tom B
Details
screenshot of problem in firefox (679.80 KB, image/jpeg)
2020-01-14 12:13 UTC, Tom B
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom B 2020-01-14 12:11:36 UTC
Created attachment 125117 [details]
screenshot of problem

SUMMARY

Under wayland, some windows are given the incorrect window decorations.

Two distinct issues occur.

1. The minimize and maximize buttons are not shown
2. A gap is drawn around the window when it shouldn't be.

So far I have found two windows with this problem. 

STEPS TO REPRODUCE
1. Open Lutris in KDE wayland

Or 

1. Start firefox with wayland enabled: MOZ_ENABLE_WAYLAND=1 firefox
2. Go to menu > customize
3. Untick "Title Bar" at the bottom


OBSERVED RESULT

1. No minimize or maximize button
2. Additional gap drawn around window

EXPECTED RESULT

1. Correct titlebar buttons appear
2. No gap drawn around the window

SOFTWARE/OS VERSIONS


KDE Plasma Version: 5.17.5
Comment 1 Tom B 2020-01-14 12:13:18 UTC
Created attachment 125118 [details]
screenshot of problem in firefox
Comment 2 David Edmundson 2020-01-14 12:15:44 UTC
Those decorations are being drawn by the client, which means the problem lies with a combination of that client, that client's toolkit (GTK) and the breeze GTK theme.

Kwin isn't really involved.

I'll move this to our GTK theme.
Comment 3 Vlad Zahorodnii 2020-01-15 13:18:47 UTC
> 2. No gap drawn around the window
You're on X11, right? "Fixed" in 5.18.

> 1. Correct titlebar buttons appear
Firefox does its own headerbar thing so I recommend to report this bug to Firefox developers, but just to be sure, could you please attach your .config/gtk-3.0/settings.ini to this bug report?
Comment 4 Tom B 2020-01-15 13:22:32 UTC
> You're on X11, right? "Fixed" in 5.18.

I'm on Wayland and this only happens on Wayland.

> Firefox does its own headerbar thing so I recommend to report this bug to Firefox developers, but just to be sure, could you please attach your .config/gtk-3.0/settings.ini to this bug report?

I reported it to firefox: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=wayland+firefox+window+decorations

And to Lutris: https://github.com/lutris/lutris/issues/2575 who said "not our bug"



.config/gtk-3.0/settings.ini     

                                                                               
[Settings]
gtk-application-prefer-dark-theme=true
gtk-button-images=0
gtk-cursor-theme-name=breeze_cursors
gtk-fallback-icon-theme=Adwaita
gtk-font-name=Noto Sans Regular 10
gtk-icon-theme-name=breeze
gtk-menu-images=0
gtk-primary-button-warps-slider=0
gtk-theme-name=Breeze-Dark
gtk-toolbar-style=GTK_TOOLBAR_ICONS
Comment 5 Tom B 2020-02-14 20:49:16 UTC
This has been fixed in 5.18. There is a different Breeze GTK bug but I'll report that separately.