Bug 416236 - Share some code parts with Dolphin to make both behave consistent
Summary: Share some code parts with Dolphin to make both behave consistent
Status: RESOLVED MOVED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: Open/save dialogs (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR task
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-14 10:18 UTC by postix
Modified: 2020-01-29 19:14 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshots: Summary of the text (except the described bugs) (1002.39 KB, image/png)
2020-01-14 10:18 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-01-14 10:18:45 UTC
Created attachment 125110 [details]
Screenshots: Summary of the text (except the described bugs)

Both Dolphin and the open/save dialog are pretty similar: 

* Places panel
* View engine's
* Previews

yet they behave differently with different tiny bugs:

* The open/save dialog does not have a context menu to adjust the places panel and the columns in the details-view just like Dolphin has
* The margins of files and folders are different for both in all views
* The open/save dialog has white fonts while Dolphin has gray fonts for attributes in the details view
* The open/save dialog does not display emblems on folders
* Dolphin's selection background only covers the icon and filename, while open/save dialog highlights the whole column
* There are different bugs for both when resizing the columns and the icon + filename no longer fits into the column


Wouldn't it make it a lot easier and reduce the amount for maintenance if both shared the same code and style?
Comment 1 Nate Graham 2020-01-29 19:14:47 UTC
It would indeed, it's just that doing so is extraordinarily complex and difficult. Thankfully, parts of it are already happening!

The Places panel will be unified between the two with https://phabricator.kde.org/D26067 and Kai's Dolphin branch to use that code (https://cgit.kde.org/dolphin.git?h=broulik%2Fkfileplacesview).

Unifying the view engine code is tracked with https://phabricator.kde.org/T9226.

The preview code is already in a framework and kio-extras and is shared between them, so nothing needs to be done there.