Bug 416232 - Stop using lighter text for columns in details view
Summary: Stop using lighter text for columns in details view
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: details mode (show other bugs)
Version: 19.12.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-14 09:34 UTC by postix
Modified: 2020-11-19 18:20 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot. Top: Dolphin, bottom: Open/Save dialog (97.18 KB, image/png)
2020-01-14 09:34 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-01-14 09:34:27 UTC
Created attachment 125108 [details]
Screenshot. Top: Dolphin, bottom: Open/Save dialog

SUMMARY

Dolphin displays the attributes "size", "type" etc. in the list in a gray font with a low contrast compared to the dark background.
IMHO the open/save dialog does it better: Though it seems to resemble Dolphin quiet a lot, it Displays those attributes in a white font.

Please see the screenshot.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Comment 1 Nate Graham 2020-01-14 17:18:47 UTC
This is easy enough to fix, but it looks intentional. Generally, having the text be slightly lighter is supposed to de-emphasize it so your eye isn't drawn in multiple directions. We do this all over the place. However I will admit that doing it in certain columns of a multi-column view is a bit unusual.

Needs VDG input (CCd).
Comment 2 Andres Betts 2020-01-14 17:20:41 UTC
I don't see a problem with this. My only word of caution is to be a good judge of contrast so that it doesn't seem like it is burning on the screen.
Comment 3 Nate Graham 2020-01-14 17:32:02 UTC
Well the problem is that it's inconsistent. Dolphin does it, but the file dialogs don't. Other table views such as the one in KSysGuard also don't.

If we want to keep it in Dolphin, we should probably at least make the file dialogs look the same when using a multi-column table view.
Comment 4 Andres Betts 2020-01-14 17:38:00 UTC
Are you for expanding the reach of this patch? Or, should we not consider it because it will cause visual inconsistency?
Comment 5 Nate Graham 2020-01-14 17:55:15 UTC
There is no patch, this is a bug report. :)

That's the question: should we make the file dialog look more like Dolphin and use lighter text for text in other columns, or should we make Dolphin stop doing that? I'm asking for VDG opinions on this.
Comment 6 Andres Betts 2020-01-14 17:56:13 UTC
I would probably like to see more examples of what this would look like outside of dolphin to see if it is too distracting.
Comment 7 Nate Graham 2020-11-19 18:20:05 UTC
Code-wise, this is trivially done by removing the line "painter->setPen(m_additionalInfoTextColor);" in kstandarditemlistwidget.cpp, which causes it to fall back to the default text color.

However this has the effect of causing additional information text in icon view to also be drawn using the default font color rather than a lightened version of it. I haven't yet found a way to only make this change for the columns in list view.