Bug 416153 - Allow Night color temperature adjustment with mouse wheel
Summary: Allow Night color temperature adjustment with mouse wheel
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasmashell
Classification: Plasma
Component: Brightness and Color widget (show other bugs)
Version: 5.93.0
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 418193 444144 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-01-12 10:35 UTC by Patrick Silva
Modified: 2024-05-02 23:35 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-01-12 10:35:54 UTC
SUMMARY
Plasma 5.18 will have an applet to enable/disable Night Color feature from systray. \o/
Possibility to adjust the color temperature by moving the mouse wheel on its icon like we can do with Redshift applet would be very nice.
Comment 1 Nate Graham 2020-02-26 18:57:18 UTC
*** Bug 418193 has been marked as a duplicate of this bug. ***
Comment 2 Patrick Silva 2021-10-21 03:42:52 UTC
*** Bug 444144 has been marked as a duplicate of this bug. ***
Comment 3 Oliver Beard 2023-01-04 04:36:55 UTC
I'm thinking about how this would be implemented. Presumably, the applet would need to change the config (kwinrc NightColor) as the KCM does?
Comment 4 David 2023-01-04 10:15:04 UTC
(In reply to Oliver Beard from comment #3)
> I'm thinking about how this would be implemented. Presumably, the applet
> would need to change the config (kwinrc NightColor) as the KCM does?

Maybe you could copy the UI from the redshift control widget: https://github.com/kotelnik/plasma-applet-redshift-control
Comment 5 Nate Graham 2024-04-09 14:11:01 UTC
I think unfortunately we have to say no to this, since the Night Color widget was merged with the Brightness widget which already changes the *screen* brightness with a scroll. This means we can't make anything else change on scroll.

Conceivably we could offer a configuration option to let people choose what gets changed when scrolling, but that's kind of a crazy overkill feature IMO, and would lead to basically dead code since almost nobody would ever change the setting.

There's also the option for us to dynamically change what a scroll does based on what the current state is; when Night Light is active, we could have a scroll change the color temperature rather than the screen brightness for example. This might work better, but I think it would be unexpected for the UX to change like this.

As a result for now we have to say no to this feature. Sorry to everyone who was holding out hope for it.
Comment 6 Natalie Clarius 2024-04-09 14:11:52 UTC
Since Night Light has now been integrated into the Brightness applet where scrolling already changes screen brightness, we can't really have both.  
I also think that it's better to have applet actions reserved for on-the-fly changes to state that changes between sessions, and leave permanent configuration (such as night temperature) to the system settings.
Comment 7 David 2024-04-09 15:44:30 UTC
(In reply to Natalie Clarius from comment #6)
> Since Night Light has now been integrated into the Brightness applet where
> scrolling already changes screen brightness, we can't really have both.  
> I also think that it's better to have applet actions reserved for on-the-fly
> changes to state that changes between sessions, and leave permanent
> configuration (such as night temperature) to the system settings.

I think it'd be quite inconsistent to have clicks control night temperature on/off but scrolls control brightness.

It'd also be quite a breaking change compared to the widget which this is meant to supercede:
https://github.com/KDE/plasma-redshift-control
Comment 8 Natalie Clarius 2024-04-09 16:07:44 UTC
The switch doesn't disable night light line setting it to "off" in the system settings module does, it just pauses it. Though admittedly that distinction is not very obvious.
Comment 9 Natalie Clarius 2024-04-09 16:08:46 UTC
(The switch in the applet or middle click I meant).
Comment 10 Bug Janitor Service 2024-04-25 01:02:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4262
Comment 11 Natalie Clarius 2024-05-02 23:35:40 UTC
Git commit 0af47262d53f6b5acd515f9a255cb2e2b409fb15 by Natalie Clarius.
Committed on 02/05/2024 at 23:19.
Pushed by nclarius into branch 'master'.

applets/brightness: clarify UI of Night Light inhibition

To clarify that the toggle action (switch and middle-click in the applet) for Night Light merely temporarily disables the blue light filter, rather than turning the schedule off permanently like the "Disabled" setting in the KCM does,
- use "suspended/resume" terminology instead of "off/on",
- set a label on the switch,
- turn the switch around so that the on state means inhibited, so that the UI becomes similar to "Do not disturb mode" in the notification applet.

M  +3    -2    applets/brightness/package/contents/ui/NightLightItem.qml
M  +7    -3    applets/brightness/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/0af47262d53f6b5acd515f9a255cb2e2b409fb15