Bug 415944 - 7.0.0beta2 removed all my Geolocation bookmarks
Summary: 7.0.0beta2 removed all my Geolocation bookmarks
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Geolocation-Bookmarks (show other bugs)
Version: 7.0.0
Platform: Appimage Linux
: NOR major
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-06 20:45 UTC by Jens
Modified: 2020-01-06 22:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2020-01-06 20:45:04 UTC
SUMMARY
I updated to 7.0.0beta2 from 6.4.0.
After updating, my geolocation bookmarks are gone.



Using the appimage from files.kde.org/digikam, on KDE Neon 18.04 LTS, with all updates applied. (KDE Plasma desktop)
Comment 1 Jens 2020-01-06 20:47:37 UTC
Update: Geolocation bookmarks are also not saved / kept when I add new ones.
Comment 2 Maik Qualmann 2020-01-06 20:56:33 UTC
The bookmark file should be here: "$HOME/.local/share/digikam/geobookmarks.xml". Does it exist?

Maik
Comment 3 Maik Qualmann 2020-01-06 20:59:13 UTC
I can confirm the problem.

Maik
Comment 4 Maik Qualmann 2020-01-06 21:44:14 UTC
Git commit 854df06b00230e9fc23ec04ad3d448c9319cf64b by Maik Qualmann.
Committed on 06/01/2020 at 21:43.
Pushed by mqualmann into branch 'master'.

revert using QSharedPointer for BookmarkNode

M  +19   -19   core/utilities/geolocation/geoiface/bookmark/bookmarknode.cpp

https://invent.kde.org/kde/digikam/commit/854df06b00230e9fc23ec04ad3d448c9319cf64b
Comment 5 Maik Qualmann 2020-01-06 22:17:54 UTC
Git commit 278943cbfbe1201c90bd5514bfd9afe416441039 by Maik Qualmann.
Committed on 06/01/2020 at 22:17.
Pushed by mqualmann into branch 'master'.

fix memory leak from BookmarkNodes
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +1    -0    core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp
M  +1    -2    core/utilities/geolocation/geoiface/bookmark/bookmarknode.cpp
M  +1    -0    core/utilities/geolocation/geoiface/bookmark/bookmarksmngr.cpp

https://invent.kde.org/kde/digikam/commit/278943cbfbe1201c90bd5514bfd9afe416441039