Bug 415939 - dataengines/geolocation/location_gps.cpp build failure with libgps 3.20
Summary: dataengines/geolocation/location_gps.cpp build failure with libgps 3.20
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: DataEngines (show other bugs)
Version: master
Platform: Kubuntu Linux
: NOR major
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-06 16:58 UTC by Rik Mills
Modified: 2020-01-07 21:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2020-01-06 16:58:54 UTC
SUMMARY

with libgps/gpsd dataengines/geolocation/location_gps.cpp has the following build failure:

/<<BUILDDIR>>/plasma-workspace-5.17.80+p20.04+git20200106.1614/dataengines/geolocation/location_gps.cpp:62:28: error: could not convert ‘((Gpsd*)this)->Gpsd::m_gpsdata->gps_data_t::online’ from ‘timespec_t’ {aka ‘timespec’} to ‘bool’
   62 |             if (m_gpsdata->online) {
      |                 ~~~~~~~~~~~^~~~~~
      |                            |
      |                            timespec_t {aka timespec}
make[3]: *** [dataengines/geolocation/CMakeFiles/plasma-geolocation-gps.dir/build.make:79: dataengines/geolocation/CMakeFiles/plasma-geolocation-gps.dir/location_gps.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs...

gpsd/libgps 3.20 just landied in debian unstable and Ubuntu 20.04 dev archives: https://launchpad.net/ubuntu/+source/gpsd/

Build failure picked up on Kubuntu CI on 1st build with 3.20 available.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.17.80+git (git master)
KDE Frameworks Version: 5.66+git (git master)
Qt Version: 5.12.5
Comment 1 Rik Mills 2020-01-06 17:19:26 UTC
5.17.4 also fails to build in the same fashion.
Comment 2 Antonio Rojas 2020-01-06 19:24:46 UTC
I was surprised that they hadn't bumped the soname, looks like it was an oversight after all. 

Anyway, https://phabricator.kde.org/D26474