Bug 415938 - KF5AuthMacros uses deprecated DBUS_SYSTEM_SERVICES_INSTALL_DIR (not set with KDE_INSTALL_DIRS_NO_DEPRECATED)
Summary: KF5AuthMacros uses deprecated DBUS_SYSTEM_SERVICES_INSTALL_DIR (not set with ...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kauth
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.65.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-06 16:37 UTC by Friedrich W. H. Kossebau
Modified: 2020-09-16 12:56 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kauth/commit/0068b2176afeb8661b8b26950c9bee79c8fb86ec
Version Fixed In: 5.75

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2020-01-06 16:37:05 UTC 
KAUTH_INSTALL_HELPER_FILES code uses the deprecated DBUS_SYSTEM_SERVICES_INSTALL_DIR variable, which will not be set when KDE_INSTALL_DIRS_NO_DEPRECATED is set, so the code will fail.
Comment 1 Harald Sitter 2020-09-05 16:35:00 UTC 
KDE_INSTALL_DBUSSERVICEDIR replaces it?
Comment 2 Friedrich W. H. Kossebau 2020-09-05 16:49:03 UTC 
https://api.kde.org/ecm/kde-module/KDEInstallDirs.html says that it is KDE_INSTALL_DBUSSYSTEMSERVICEDIR
Comment 3 Bug Janitor Service 2020-09-05 17:38:19 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kauth/-/merge_requests/5
Comment 4 Harald Sitter 2020-09-16 12:56:36 UTC 
Git commit 0068b2176afeb8661b8b26950c9bee79c8fb86ec by Harald Sitter.
Committed on 16/09/2020 at 12:56.
Pushed by sitter into branch 'master'.

use new install var

DBUS_SYSTEM_SERVICES_INSTALL_DIR is deprecated,
KDE_INSTALL_DBUSSYSTEMSERVICEDIR is not. use the latter.

we depend on latest ECM anyway, what with it being a framework, so we
can use the not deprecated version easy peasy
FIXED-IN: 5.75

M  +1    -1    cmake/KF5AuthMacros.cmake

https://invent.kde.org/frameworks/kauth/commit/0068b2176afeb8661b8b26950c9bee79c8fb86ec