Bug 415896 - Stroke selection doesn't work for some selection tools
Summary: Stroke selection doesn't work for some selection tools
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-05 14:48 UTC by acc4commissions
Modified: 2020-01-08 13:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2020-01-05 14:48:21 UTC
SUMMARY
More specifically it only works for Rectangular, Elliptical, Poligonal Selection Tools and doesn't work for the others(Outline, Contiguous, Similar Color, Bezier, Magnetic).

If that's intentional I think Krita should hide the Stroke Selection menu on those tools(and any other features that doesn't work for them). 


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 vanyossi 2020-01-05 23:26:14 UTC
Tested in 7ef60648faf92 all selections stroke normally for me either in vector or pixel mode. What could be different in your setup that it doesn't work for some?

Are you stroking with current brush or with solid line? some brushes could have some sensors dependant on tablet information that could prevent them to work. But that should have the same effect for all selections.

What git hash are you on?
Comment 2 acc4commissions 2020-01-06 14:17:13 UTC
Sorry for not giving enough informations. 


Krita

 Version: 4.3.0-prealpha (git 9d531f2)
 Languages: en_US, en, en_US, en, en_US, en, en_US, en, en_US, en
 Hidpi: false

Qt

  Version (compiled): 5.12.5
  Version (loaded): 5.12.5

OS Information

  Build ABI: x86_64-little_endian-llp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: winnt
  Kernel Version: 6.1.7601
  Pretty Productname: Windows 7 SP 1 (6.1)
  Product Type: windows
  Product Version: 7sp1

OpenGL Info
 
  Vendor:  "ATI Technologies Inc." 
  Renderer:  "Radeon RX 560 Series" 
  Version:  "3.0.13558 Compatibility Profile Context 26.20.11015.5009" 
  Shading language:  "4.60" 
  Requested format:  QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::CompatibilityProfile) 
  Current format:    QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples 0, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 1, colorSpace QSurfaceFormat::sRGBColorSpace, profile  QSurfaceFormat::NoProfile) 
     Version: 3.0
     Supports deprecated functions true 
     is OpenGL ES: false 

QPA OpenGL Detection Info 
  supportsDesktopGL: true 
  supportsAngleD3D11: true 
  isQtPreferAngle: false 

Hardware Information

  GPU Acceleration: auto
  Memory: 16351 Mb
  Number of Cores: 8
  Swap Location: C:/Users/---------/AppData/Local/Temp

Current Settings

  Current Swap Location: C:/Users/---------/AppData/Local/Temp
  Undo Enabled: 1
  Undo Stack Limit: 530
  Use OpenGL: 1
  Use OpenGL Texture Buffer: 1
  Use AMD Vectorization Workaround: 0
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 120
  Use Backup Files: 1
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Use Win8 Pointer Input: 0
  Use RightMiddleTabletButton Workaround: 0
  Levels of Detail Enabled: 0
  Use Zip64: 0




And it doesn't work in 4.2.8 neither on my system.
Comment 3 Bug Janitor Service 2020-01-07 04:33:10 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 4 Halla Rempt 2020-01-07 13:01:03 UTC
There is something weird going on with this dialog. For me, most options are always disabled and the layout is messed up.
Comment 5 Halla Rempt 2020-01-07 14:09:09 UTC
Git commit 94dc6c1a404119a26fc3ff9e27fab63e2e1256e5 by Boudewijn Rempt.
Committed on 07/01/2020 at 14:07.
Pushed by rempt into branch 'master'.

Fix logic for enabling/disabling options in stroke selection dialog

M  +79   -91   libs/ui/dialogs/kis_dlg_stroke_selection_properties.cpp
M  +12   -8    libs/ui/dialogs/kis_dlg_stroke_selection_properties.h
M  +190  -152  libs/ui/forms/wdgstrokeselectionproperties.ui
M  +2    -0    libs/ui/kis_selection_manager.cc

https://invent.kde.org/kde/krita/commit/94dc6c1a404119a26fc3ff9e27fab63e2e1256e5
Comment 6 acc4commissions 2020-01-07 20:11:15 UTC
After I updated to git 04d1174 it works fine. Is it that the patch has applied?

And when I try to use it on ventor layer all the options in Stroke Selection are disabled except for 'Line', which is the line color option. Is this intentional?
Comment 7 acc4commissions 2020-01-07 20:25:27 UTC
(In reply to acc4commissions from comment #6)
> After I updated to git 04d1174 it works fine. Is it that the patch has
> applied?
> 
> And when I try to use it on ventor layer all the options in Stroke Selection
> are disabled except for 'Line', which is the line color option. Is this
> intentional?

ventor -> vector
Comment 8 Halla Rempt 2020-01-08 09:04:58 UTC
Yes -- vector shapes cannot be drawn with the raster brushes.
Comment 9 acc4commissions 2020-01-08 11:28:46 UTC
1 After updated to git 0875026(which says this patch has been applied to it) Stroke Selection works on vector layers. Just wanted to report, and hope it's not a bug or an accident.

2 Apparently the original issue has been solved before this patch, because it already worked when I updated to git 04d1174. Again, hope it's not a bug or an accident.
Comment 10 acc4commissions 2020-01-08 11:42:55 UTC
(In reply to acc4commissions from comment #9)
> 1 After updated to git 0875026(which says this patch has been applied to it)
> Stroke Selection works on vector layers. Just wanted to report, and hope
> it's not a bug or an accident.
> 
> 2 Apparently the original issue has been solved before this patch, because
> it already worked when I updated to git 04d1174. Again, hope it's not a bug
> or an accident.

I take back what I said about the vector layer. It seems to work like it's supposed to.
Comment 11 Halla Rempt 2020-01-08 13:56:23 UTC
Git commit d921fa60a37cab528855919ebf124426bb2c0dbf by Boudewijn Rempt.
Committed on 08/01/2020 at 13:34.
Pushed by rempt into branch 'krita/4.2'.

Fix logic for enabling/disabling options in stroke selection dialog
(cherry picked from commit 94dc6c1a404119a26fc3ff9e27fab63e2e1256e5)

M  +79   -91   libs/ui/dialogs/kis_dlg_stroke_selection_properties.cpp
M  +12   -8    libs/ui/dialogs/kis_dlg_stroke_selection_properties.h
M  +190  -152  libs/ui/forms/wdgstrokeselectionproperties.ui
M  +2    -0    libs/ui/kis_selection_manager.cc

https://invent.kde.org/kde/krita/commit/d921fa60a37cab528855919ebf124426bb2c0dbf