Bug 415849 - umbrello/KF5 does not provide PHP Importer
Summary: umbrello/KF5 does not provide PHP Importer
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: importer (show other bugs)
Version: 2.30.0 (KDE Applications 19.12.0)
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-03 18:40 UTC by Ralf Habacker
Modified: 2020-01-05 10:22 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/kde/umbrello/commit/22c769b39c1f53db16c6c40f98a30fd7b5125907
Version Fixed In: 2.30.1 (KDE Appplications 19.12.1)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2020-01-03 18:40:09 UTC 
Building umbrello/KF5 with kdevplatform compiled without BUILD_TESTING prevents compiling php import support

Kevin Funk mentioned in bug 409951 comment 7 the following solution for the missing KDev::Tests target.

"I'd just create and shut down the core manually in your code. And provide a custom ShellExtension subclass. Shouldn't be difficult, and it could result in even less code than in the implementation(s) provided in KDev::Tests."
Comment 1 Ralf Habacker 2020-01-04 18:06:17 UTC 
Git commit c7488f8a561d5e34106c5c76bc2ce5323feafd38 by Ralf Habacker.
Committed on 04/01/2020 at 18:04.
Pushed by habacker into branch 'release/19.12'.

Embed KDev::Tests library to not depend on kdevplatform for KF5 builds

The KDevelopUtils::DebugLanguageParserHelper class provided by kdevplatform
depends on KDev::Tests, which is not exported by default (it requires the
BUILDING_TESTS setting), which means we must provide KDev::Tests locally.

M  +4    -6    CMakeLists.txt
M  +1    -0    lib/kdev5-php/CMakeLists.txt
A  +13   -0    lib/kdevplatform/CMakeLists.txt
A  +81   -0    lib/kdevplatform/shell/core_p.h     [License: LGPL (v2+)]
A  +36   -0    lib/kdevplatform/tests/autotestshell.cpp     [License: LGPL (v2+)]
A  +79   -0    lib/kdevplatform/tests/autotestshell.h     [License: LGPL (v2+)]
A  +147  -0    lib/kdevplatform/tests/testcore.cpp     [License: LGPL (v2+)]
A  +125  -0    lib/kdevplatform/tests/testcore.h     [License: LGPL (v2+)]
A  +6    -0    lib/kdevplatform/tests/testsexport.h     [License: UNKNOWN]  *

The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


https://invent.kde.org/kde/umbrello/commit/c7488f8a561d5e34106c5c76bc2ce5323feafd38
Comment 2 Ralf Habacker 2020-01-04 18:06:17 UTC 
Git commit 22c769b39c1f53db16c6c40f98a30fd7b5125907 by Ralf Habacker.
Committed on 04/01/2020 at 18:05.
Pushed by habacker into branch 'release/19.12'.

Library KDev::Tests: remove Qt5::Tests dependencies

KDev::Tests library imported from kdevplatform depends on
Qt5::Tests, which would add an unwanted extra dependency.
FIXED-IN:2.30.1 (KDE Appplications 19.12.1)

M  +0    -1    lib/kdevplatform/CMakeLists.txt
M  +5    -1    lib/kdevplatform/tests/testcore.cpp

https://invent.kde.org/kde/umbrello/commit/22c769b39c1f53db16c6c40f98a30fd7b5125907
Comment 3 Ralf Habacker 2020-01-04 22:32:16 UTC 
(In reply to Ralf Habacker from comment #0)
> "I'd just create and shut down the core manually in your code. And provide a
> custom ShellExtension subclass. Shouldn't be difficult, and it could result
> in even less code than in the implementation(s) provided in KDev::Tests."
As long as KDevelopUtils::DebugLanguageParserHelper, provided by kdevplatform and used by kdev-php5, depends on KDev::Tests, it makes no sense to port php import away from KDev::Tests.
Comment 4 Ralf Habacker 2020-01-05 09:59:41 UTC 
Git commit b554c49ac2e7dcc5063fb9260b9833dded941eab by Ralf Habacker.
Committed on 05/01/2020 at 09:59.
Pushed by habacker into branch 'release/19.12'.

Limit building local KDev::Tests library for KF5 only when kdevplatform library has been found

This fixes a CI build error in case kdevplatform development package was not installed

CCMAIL:cfeck@kde.org

M  +1    -3    CMakeLists.txt
M  +13   -11   lib/kdevplatform/CMakeLists.txt

https://invent.kde.org/kde/umbrello/commit/b554c49ac2e7dcc5063fb9260b9833dded941eab