Bug 415805 - ToolButtons do not indicate keyboard focus
Summary: ToolButtons do not indicate keyboard focus
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-01-02 15:02 UTC by David Edmundson
Modified: 2021-01-11 15:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2020-01-02 15:02:52 UTC 
Press tab N times, buttons do not indicate when they have tab focus.

There is also no buddy to the "orentiation" label, making keyboard nav round here difficult.
Comment 1 Nate Graham 2020-01-02 16:11:41 UTC 
I think this is a general deficiency in our QQC2 ToolButton styling. Elisa is currently working around this issue by using Button controls with `flat: true` to mimic a toolbutton appearance, because in this mode, the button looks like a toolbutton but indicates focus with a blue outline.
Comment 2 Matthieu Gallien 2020-01-02 16:28:43 UTC 
(In reply to Nate Graham from comment #1)
> I think this is a general deficiency in our QQC2 ToolButton styling. Elisa
> is currently working around this issue by using Button controls with `flat:
> true` to mimic a toolbutton appearance, because in this mode, the button
> looks like a toolbutton but indicates focus with a blue outline.

In fact we were using tool buttons and migrated to flat buttons once support for them was added.
It felt like an abuse of ToolButton. The focus issue was just a trigger.
Comment 3 Nate Graham 2021-01-11 15:50:16 UTC 
This was fixed a couple of Frameworks versions ago.