Bug 415702 - Cannot abort or stop find Duplicate process
Summary: Cannot abort or stop find Duplicate process
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Similarity (other bugs)
Version First Reported In: 7.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-30 11:13 UTC by Alexandre Belz
Modified: 2020-01-02 20:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 7.0.0
Sentry Crash Report:


Attachments
DebugView Log file (2.01 MB, text/plain)
2019-12-30 11:13 UTC, Alexandre Belz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Belz 2019-12-30 11:13:42 UTC
Created attachment 124784 [details]
DebugView Log file

STEPS TO REPRODUCE
1. Run fingerprint process
2. Run Duplicate process
3. Look at the progress bar and Hit the Cancel icon [0]

OBSERVED RESULT
"Aborting" is displayed but the process still runs.
Closing digikam does not help.
I need to kill the process from Windows task manager.

EXPECTED RESULT
The duplicate search process should stop & abort.
Closing digikam should also stop the duplicate searching process properly.

SOFTWARE/OS VERSIONS
Windows: 10
Comment 1 Maik Qualmann 2019-12-30 11:23:22 UTC
Problem is known and only affects the Windows version. By using a new signal/slot method that requires a C++11 compiler, the canceling no longer works here. We have to set the compiler version for MinGW.

Maik
Comment 2 Maik Qualmann 2019-12-30 20:29:27 UTC
Git commit ca19063c05507c42603989d381163042157d164c by Maik Qualmann.
Committed on 30/12/2019 at 20:28.
Pushed by mqualmann into branch 'master'.

try to enable C++11 support for MinGW (untested)

M  +3    -0    core/CMakeLists.txt

https://invent.kde.org/kde/digikam/commit/ca19063c05507c42603989d381163042157d164c
Comment 3 Alexandre Belz 2019-12-30 20:34:23 UTC
Thank you Maik,
Will test at next windows build.
Comment 4 caulier.gilles 2019-12-30 21:13:57 UTC
I will rebuild all windows bundles tomorrow morning...

Gilles
Comment 5 Maik Qualmann 2019-12-31 14:35:27 UTC
Unfortunately not fixed yet...

Maik
Comment 6 Maik Qualmann 2019-12-31 16:17:29 UTC
Git commit c0a607061f979a712b685e81d6277a2463e8cf27 by Maik Qualmann.
Committed on 31/12/2019 at 16:16.
Pushed by mqualmann into branch 'master'.

try with add namespace to ProgressItem

M  +1    -1    core/utilities/maintenance/maintenancetool.cpp

https://invent.kde.org/kde/digikam/commit/c0a607061f979a712b685e81d6277a2463e8cf27
Comment 7 Maik Qualmann 2020-01-01 07:34:07 UTC
Git commit a69c33aa2a73eb875ca228ab70e97a8c197db89a by Maik Qualmann.
Committed on 01/01/2020 at 07:32.
Pushed by mqualmann into branch 'master'.

next try to fix signal/slot in the maintenance tool

M  +1    -1    core/utilities/maintenance/maintenancetool.cpp

https://invent.kde.org/kde/digikam/commit/a69c33aa2a73eb875ca228ab70e97a8c197db89a
Comment 8 Alexandre Belz 2020-01-01 12:01:00 UTC
Maik,
for information, aborting "People\face detection" does work correctly (the process stops when I ask it to abort).

Is there a different method invoked to stop the two different process ?
Comment 9 Maik Qualmann 2020-01-02 19:03:13 UTC
Git commit e4a4fc3e7d3fd9e4aac5faa1583a67ec298b57a4 by Maik Qualmann.
Committed on 02/01/2020 at 19:02.
Pushed by mqualmann into branch 'master'.

use the old signal/slot method for Windows
FIXED-IN: 7.0.0

M  +1    -1    NEWS
M  +8    -2    core/utilities/maintenance/maintenancetool.cpp

https://invent.kde.org/kde/digikam/commit/e4a4fc3e7d3fd9e4aac5faa1583a67ec298b57a4
Comment 10 Alexandre Belz 2020-01-02 20:34:08 UTC
Thank you Maik !
will test asap.