Bug 415677 - OverlaySheet constrains width of content to be much too small
Summary: OverlaySheet constrains width of content to be much too small
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-29 15:03 UTC by Nate Graham
Modified: 2020-01-13 15:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Sheet's contents are squeezed into a narrow strip with huge side margins (3.28 MB, video/webm)
2019-12-29 15:03 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-12-29 15:03:30 UTC
Created attachment 124772 [details]
Sheet's contents are squeezed into a narrow strip with huge side margins

I am working on the review sheet in Discover (https://phabricator.kde.org/D25889), which uses a Kirigami OverlaySheet to display a list of an app's user reviews.

The internal layouting of the OverlaySheet sizes the content to be narrow and centered within the sheet, with enormous side margins. This leaves little horizontal space for the content itself, and IMO just doesn't look very good. See attached screen recording.

The bug seems to be caused by or near https://cgit.kde.org/kirigami.git/tree/src/controls/templates/OverlaySheet.qml#n211, but I was unable to pinpoint exactly where or formulate a patch, sorry.