Bug 415666 - On settings page, native distro software sources button is missing (git master)
Summary: On settings page, native distro software sources button is missing (git master)
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Kubuntu Linux
: NOR major
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-29 07:57 UTC by Rik Mills
Modified: 2019-12-31 09:08 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/discover/a6f7aaa67aca9864f7802d170ec6a408176c6870
Version Fixed In:

Attachments
Settings page at 1st bad revision (174.50 KB, image/png)
2019-12-29 07:59 UTC, Rik Mills 		Details
Settings page at last good revision (112.41 KB, image/png)
2019-12-29 08:00 UTC, Rik Mills 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2019-12-29 07:57:01 UTC 
SUMMARY

In current git master on settings page, native distro software sources button is now missing.

Performing a git bisect shows that the 1st bad commit is:

https://cgit.kde.org/discover.git/commit/?id=89088f7639a63c0c099ccb9c95393f12d83c17b5

"Improve Sources page on Plasma Mobile"

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu
KDE Plasma Version: git master (5.17.80+git)
KDE Frameworks Version: 5.65+git
Qt Version: 5.12.5
Comment 1 Rik Mills 2019-12-29 07:59:39 UTC 
Created attachment 124766 [details]
Settings page at 1st bad revision

Settings page at 1st bad revision
Comment 2 Rik Mills 2019-12-29 08:00:41 UTC 
Created attachment 124767 [details]
Settings page at last good revision

Settings page at last good revision
Comment 3 Aleix Pol 2019-12-30 17:58:41 UTC 
I couldn't reproduce as is. Can you check that you have /usr/share/applications/software-properties-qt.desktop?
Comment 4 Rik Mills 2019-12-30 18:15:37 UTC 
(In reply to Aleix Pol from comment #3)
> I couldn't reproduce as is. Can you check that you have
> /usr/share/applications/software-properties-qt.desktop?

I do.

If I did not, I would not be able to identify in a git bisect which commit make it vanish.
Comment 5 Aleix Pol 2019-12-31 01:39:07 UTC 
Git commit a6f7aaa67aca9864f7802d170ec6a408176c6870 by Aleix Pol.
Committed on 31/12/2019 at 01:38.
Pushed by apol into branch 'master'.

sources: fix source actions in older versions of Qt

QList is not iterable over there, so we had to turn it into a QVariantList.

M  +2    -2    libdiscover/backends/DummyBackend/DummySourcesBackend.cpp
M  +1    -1    libdiscover/backends/DummyBackend/DummySourcesBackend.h
M  +4    -3    libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.cpp
M  +1    -1    libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.h
M  +1    -1    libdiscover/backends/FlatpakBackend/tests/FlatpakTest.cpp
M  +1    -1    libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp
M  +1    -1    libdiscover/backends/FwupdBackend/FwupdSourcesBackend.h
M  +2    -2    libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.cpp
M  +2    -2    libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.h
M  +1    -1    libdiscover/backends/SnapBackend/SnapBackend.cpp
M  +2    -2    libdiscover/resources/AbstractSourcesBackend.h

https://commits.kde.org/discover/a6f7aaa67aca9864f7802d170ec6a408176c6870
Comment 6 Rik Mills 2019-12-31 09:08:57 UTC 
Can confirn fixed in Kubuntu CI builds.

Thank you Aleix :)