Bug 415649 - Change option to 'Open groups in popups, only when Task Manager is full'.
Summary: Change option to 'Open groups in popups, only when Task Manager is full'.
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: master
Platform: unspecified Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-28 16:39 UTC by gvgeo
Modified: 2020-02-18 04:49 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-desktop/c32b5a85cae6f99bb5097b16a25983fc611aecc6
Version Fixed In: 5.19.0

Attachments
Rename suggestion. (8.28 KB, image/png)
2019-12-28 16:39 UTC, gvgeo 		Details
Options 1, 2, 3 (9.97 KB, image/png)
2019-12-29 15:23 UTC, gvgeo 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description gvgeo 2019-12-28 16:39:51 UTC 
Created attachment 124761 [details]
Rename suggestion.

SUMMARY
Change 'Group only when the Task Manager is full' to combine groups to single task only when Task Manager is full.

OBSERVED RESULT
The only way to have tasks always grouped, is to either have task always compined or always separated.
The 'Group only when the Task Manager is full' ungroups tasks.

EXPECTED RESULT
Ability to have groups, without merging to single task, while giving the option to merge if taskbar is full.

KDE Plasma Version: 5.17.4

On that note, also suggest to rename 'Open groups in popups', to 'Combine groups to single tasks'.
Comment 1 Eike Hein 2019-12-29 10:50:24 UTC 
Sorry, I don't understand your report at all. Could you try explaining it differently?
Comment 2 gvgeo 2019-12-29 15:23:15 UTC 
Created attachment 124773 [details]
Options 1, 2, 3

Currently:
Option 3 affects option 1 instead of 2.

Request:
Add an option 4, to affect option 2.
Comment 3 Eike Hein 2019-12-29 16:00:25 UTC 
Thanks.

Yes, it looks like someone broke the UI design recently when they rewrote that settings page - this option indentation makes no sense as the options are not conditional like this.
Comment 4 Nate Graham 2020-01-14 17:45:03 UTC 
Sorry, that someone was probably me when I re-did this to make it use FormLayouts.

Happily, George submitted a patch to fix it (and improve other things): https://phabricator.kde.org/D26660
Comment 5 Nate Graham 2020-02-18 04:49:46 UTC 
Git commit c32b5a85cae6f99bb5097b16a25983fc611aecc6 by Nate Graham, on behalf of George Vogiatzis.
Committed on 18/02/2020 at 04:49.
Pushed by ngraham into branch 'master'.

[Applets/Task Manager] Fix and improve behavior tab layouts

Summary:
Fix the group layout.
Change rest of behavior tab layout.
Rename various labels and texts.
FIXED-IN: 5.19.0

Test Plan:
Before:
The indentation of option "Group only when the Task Manager is full"
is misleading.

Before:
{F7882775, layout=inline} {F7882776, layout=inline}

After:
{F7883513, layout=inline} {F7882780, layout=inline}

Reviewers: #vdg, #plasma, hein, ngraham

Reviewed By: #vdg, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26660

M  +16   -19   applets/taskmanager/package/contents/ui/ConfigBehavior.qml

https://commits.kde.org/plasma-desktop/c32b5a85cae6f99bb5097b16a25983fc611aecc6