Bug 415539 - Button text "Download New %1" should have ellipsis according to HIG
Summary: Button text "Download New %1" should have ellipsis according to HIG
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.65.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2019-12-25 01:11 UTC by Alexander Potashev
Modified: 2020-01-14 17:32 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/knewstuff/36c798cd0bc8011119b0acdebea23e3474528190
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2019-12-25 01:11:46 UTC 
SUMMARY
Button text "Download New %1" should have ellipsis according to HIG.

https://hig.kde.org/style/writing/labels.html
"End the label with an ellipsis if the command requires additional user interaction to complete."

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
see in src/qtquick/qml/Button.qml
Comment 1 Dan Leinir Turthra Jensen 2019-12-26 14:27:12 UTC 
That it most definitely should, good catch :) This is even the sort of thing i try and catch, so i feel all manner of dirty for missing it in code i wrote myself ;)