Bug 415502 - Searching spinner is blurry on HiDPI
Summary: Searching spinner is blurry on HiDPI
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.9.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-23 20:04 UTC by postix
Modified: 2020-01-15 15:32 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot of the issue. (12.55 KB, image/png)
2019-12-23 20:04 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-12-23 20:04:45 UTC
Created attachment 124677 [details]
Screenshot of the issue.

SUMMARY

Searching something (Ctrl+F) displays a spinner right to the search input field. This spinner looks blurry on HiDPI as in the screenshot.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.66.0
Qt Version: 5.13.2

ADDITIONAL INFORMATION
Scaling: 1.5
Comment 1 Oliver Sander 2019-12-24 05:31:38 UTC
That is what is fixed in https://invent.kde.org/kde/okular/merge_requests/71, right?
Comment 2 Kai Uwe Broulik 2020-01-07 11:18:48 UTC
No, because of Okular's ridiculously low Frameworks dependency.
Comment 3 Albert Astals Cid 2020-01-07 22:30:13 UTC
Let's try to be amicable and not call colleagues ridiculous, ok?

Also, i guess you know such a thing as #ifdefs exist, do you?
Comment 4 Kai Uwe Broulik 2020-01-07 23:05:48 UTC
Sorry.

I also don't care enough about the issue that I would invest anymore time in it. Was annoying enough that I had to set up a GitLab thing just to submit a twoliner. Feel free to ifdef it.
Comment 5 Oliver Sander 2020-01-12 06:51:09 UTC
For a newbie: How would the proper '#ifdef' condition look like?
Comment 6 Albert Astals Cid 2020-01-12 11:40:37 UTC
See ./shell/main.cpp:40
Comment 7 Oliver Sander 2020-01-13 20:53:28 UTC
That's not a literal recommendation, right? main.cpp:40 checks for a particular Qt version.  But we need to check for a particular frameworks version, right?  How do I do that?
Comment 8 Albert Astals Cid 2020-01-13 22:12:15 UTC
(In reply to Oliver Sander from comment #7)
> That's not a literal recommendation, right? 

Correct

>  But we need to check for a particular frameworks
> version, right?  

Yes 

> How do I do that?

Check against KWIDGETSADDONS_VERSION instead.
Comment 9 Oliver Sander 2020-01-14 05:22:39 UTC
Thanks.  The merge request now has the new code in #ifdefs.  Somebody with a post 5.61 frameworks installation please check the code for me.
Comment 10 Oliver Sander 2020-01-15 12:44:08 UTC
Fixed by 643a080410478fab2474dba58a429fc78c8dd924