Bug 415412 - ActionToolbar "more" menu visible when empty
Summary: ActionToolbar "more" menu visible when empty
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-12-20 19:41 UTC by Nicolas Fella
Modified: 2020-01-03 10:43 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/kirigami/8c09cfd92dbf67a3001b2b0de26b1f46b2d74853
Version Fixed In:
Sentry Crash Report:

Attachments
code example (556 bytes, text/x-qml)
2019-12-20 19:41 UTC, Nicolas Fella 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Fella 2019-12-20 19:41:09 UTC 
Created attachment 124628 [details]
code example

SUMMARY

When I set 'visible: false' in one of the actions inside an ActionToolbar the action is correctly not displayed, but now the overflow menu is always visible although empty. See attached code example
Comment 1 Nate Graham 2019-12-29 23:02:21 UTC 
Fixed by https://phabricator.kde.org/D26279
Comment 2 Arjen Hiemstra 2020-01-03 10:43:35 UTC 
Git commit 8c09cfd92dbf67a3001b2b0de26b1f46b2d74853 by Arjen Hiemstra.
Committed on 03/01/2020 at 10:43.
Pushed by ahiemstra into branch 'master'.

ActionToolBar: Only show the overflow button if there are visible items in the menu

Summary:
This fixes https://bugs.kde.org/show_bug.cgi?id=415412 , which was occuring because the
overflow button did not properly check to see if the actions in the menu were actually
visible.

Test Plan: The example code from the linked bug report now works correctly.

Reviewers: #kirigami, ngraham, apol

Reviewed By: #kirigami, ngraham, apol

Subscribers: apol, ngraham, plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D26279

M  +8    -1    src/controls/ActionToolBar.qml

https://commits.kde.org/kirigami/8c09cfd92dbf67a3001b2b0de26b1f46b2d74853