Bug 415260 - Regression: kate.exe has no embedded icon
Summary: Regression: kate.exe has no embedded icon
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: application (show other bugs)
Version: 19.12.0
Platform: Microsoft Windows Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-16 20:53 UTC by Alexander Potashev
Modified: 2020-01-26 12:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2019-12-16 20:53:39 UTC
SUMMARY
Regression: kate.exe has no embedded icon.

STEPS TO REPRODUCE
1. Build kate.exe from sources from Git master or install Kate with Windows installer kate-19.12.0-706-windows-msvc2017_64-cl.exe ( from https://binary-factory.kde.org/job/Kate_Release_win64/706/ )
2. Open C:\Program Files\Kate\bin\ in Windows explorer.

OBSERVED RESULT
kate.exe has the default icon for all .exe files.

EXPECTED RESULT
kate.exe should have its custom icon.

SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Guilty commit (found with git bisect): http://commits.kde.org/kate/a167b31210a059d3c57d9c955a759231a2a49d76
it is couple with another commit: http://commits.kde.org/kate/c5c2676230f59cf7f0d169aae5e3a4e9e5e23a86

I had to revert some a total of 16 commits to reproduce the bug at the closest point to current master branch:

    This reverts commit a167b31210a059d3c57d9c955a759231a2a49d76.
    This reverts commit c5c2676230f59cf7f0d169aae5e3a4e9e5e23a86.
    This reverts commit a16de6233c798cf346c881a45592495fe1829424.
    This reverts commit 63934fca756d1a627021d2f2c5e3261c48907979.
    This reverts commit ae3e2b3c5936714ec724dae2036abdb2503ec76f.
    This reverts commit d5dd4a223ec205fa0ce5ae0d1e671ade899691dc.
    This reverts commit 0636221dc0abeebc2ac6608d946ed09621ca5866.
    This reverts commit e48e411e6334dc71a7de93631b0810614768a27a.
    This reverts commit 1965302c8a74436ee9d9677759864220d117fbc7.
    This reverts commit ae8b83793859d9bf611cb8169959356b2e857fca.
    This reverts commit 565fd945b52a107c4b7b89f96146bdf8acbd9757.
    This reverts commit f3bb8f2b867ef2657f25be8a1b0c131978e0c877.
    This reverts commit f177bd36372fd06daccd8547869aed3651d43873.
    This reverts commit f8247706ec0a1505768e7ab670889f7c5aaa8741.
    This reverts commit 23d1c4009052c35c893df0973455f173dfc1cdab.
    This reverts commit 64ff574417994477e3dbdba5408641fc60ed0575.

See also https://invent.kde.org/aspotashev/kate where I applied all these reversion commits for you to test more easily.


The following mailing list thread precedes this bug report: https://mail.kde.org/pipermail/kde-windows/2019-December/thread.html#11042

I believe it's not just Kate that should be fixed, it's also ecm_add_app_icon() that must be made idiot-proof because I also couldn't get it right in KTimeTracker.
Comment 1 Alexander Potashev 2019-12-16 21:37:06 UTC
Fixed similar bug in KTimeTracker: http://commits.kde.org/ktimetracker/e712367404548bf200fb86e7ca2850f0c0785a4a

Requested documentation update for ECM: https://bugs.kde.org/show_bug.cgi?id=415263
Comment 2 Christoph Cullmann 2019-12-21 19:05:24 UTC
Git commit f9c4609b77f5ef79e42061e552c5cea1e5a1288a by Christoph Cullmann.
Committed on 21/12/2019 at 19:04.
Pushed by cullmann into branch 'master'.

try to fix embedding of icon for windows

M  +24   -24   kate/CMakeLists.txt

https://invent.kde.org/kde/kate/commit/f9c4609b77f5ef79e42061e552c5cea1e5a1288a
Comment 3 Christoph Cullmann 2019-12-21 19:05:27 UTC
Git commit f9c4609b77f5ef79e42061e552c5cea1e5a1288a by Christoph Cullmann.
Committed on 21/12/2019 at 19:04.
Pushed by scmsync into branch 'master'.

try to fix embedding of icon for windows

M  +24   -24   kate/CMakeLists.txt

https://commits.kde.org/kate/f9c4609b77f5ef79e42061e552c5cea1e5a1288a
Comment 4 Christoph Cullmann 2019-12-21 19:57:22 UTC
https://binary-factory.kde.org/job/Kate_Nightly_win64/671/ has a icon for me ;=)

Thanks for tracing this to the root cause!
Comment 5 Christoph Cullmann 2020-01-26 12:19:55 UTC
Git commit 50bddb9e2c3b86ee52c3d82cbc00907848cbdd3b by Christoph Cullmann.
Committed on 26/01/2020 at 12:19.
Pushed by cullmann into branch 'release/19.12'.

try to fix embedding of icon for windows

M  +24   -24   kate/CMakeLists.txt

https://invent.kde.org/kde/kate/commit/50bddb9e2c3b86ee52c3d82cbc00907848cbdd3b
Comment 6 Christoph Cullmann 2020-01-26 12:20:00 UTC
Git commit 50bddb9e2c3b86ee52c3d82cbc00907848cbdd3b by Christoph Cullmann.
Committed on 26/01/2020 at 12:19.
Pushed by scmsync into branch 'release/19.12'.

try to fix embedding of icon for windows

M  +24   -24   kate/CMakeLists.txt

https://commits.kde.org/kate/50bddb9e2c3b86ee52c3d82cbc00907848cbdd3b