Bug 415218 - Case-sensitivity import issue
Summary: Case-sensitivity import issue
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-15 19:06 UTC by Yurii Kolesnykov
Modified: 2020-01-08 13:56 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/kde/krita/commit/3eac2fc789435dd4de8b4b03b5e91cf3489381d4
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Yurii Kolesnykov 2019-12-15 19:06:20 UTC 
SUMMARY
https://github.com/KDE/krita/blob/8d8dc773da21a0357fd4e33e14253d5b962e9ad0/libs/ui/osx.mm#L19

STEPS TO REPRODUCE
1. Install mac on case-sensitive FS.
2. Try to build krita.

OBSERVED RESULT
It will not find `Appkit.h`, because there is capital "K" in filename.


https://github.com/KDE/krita/blob/8d8dc773da21a0357fd4e33e14253d5b962e9ad0/libs/ui/osx.mm#L19
EXPECTED RESULT
Import should take into account case-sensitivity.
Comment 1 vanyossi 2019-12-16 21:10:52 UTC 
Git commit 08e7240a6e77b8db1622256420ee56af0bbf6b9f by Ivan Yossi.
Committed on 16/12/2019 at 21:07.
Pushed by ivany into branch 'master'.

macOS: Fix case sensitive include

for macOS with case sensitive File Systems

M  +1    -1    libs/ui/osx.mm

https://invent.kde.org/kde/krita/commit/08e7240a6e77b8db1622256420ee56af0bbf6b9f
Comment 2 Halla Rempt 2020-01-08 13:56:22 UTC 
Git commit 3eac2fc789435dd4de8b4b03b5e91cf3489381d4 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 08/01/2020 at 13:33.
Pushed by rempt into branch 'krita/4.2'.

macOS: Fix case sensitive include

for macOS with case sensitive File Systems

M  +1    -1    libs/ui/osx.mm

https://invent.kde.org/kde/krita/commit/3eac2fc789435dd4de8b4b03b5e91cf3489381d4