Bug 415192 - The font increase and decrease buttons do not work
Summary: The font increase and decrease buttons do not work
Status: RESOLVED FIXED
Alias: None
Product: khelpcenter
Classification: Applications
Component: general (show other bugs)
Version: 19.12
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Documentation Editorial Team
URL:
Keywords:
: 416960 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-15 10:59 UTC by postix
Modified: 2020-01-31 06:53 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Video demonstrating my view. (491.13 KB, video/mp4)
2019-12-15 19:38 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-12-15 10:59:04 UTC
SUMMARY

The increase and decrease buttons in the KDE Helpcenter do not work as nothing happens if they are pressed.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.2
Comment 1 alexpos 2019-12-15 17:46:49 UTC
Can confirm,

the increase and decrease buttons in the KDE Helpcenter do not work as nothing happens if they are pressed.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.17 
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.2
Comment 2 Yuri Chornoivan 2019-12-15 18:09:44 UTC
(In reply to alexpos from comment #1)
> Can confirm,
> 
> the increase and decrease buttons in the KDE Helpcenter do not work as
> nothing happens if they are pressed.

Actually, it changes the size of the "next" label at the top left corner.

I would rather say that this is KHTMLPart problem as KHelpCenter itself do the right thing sending setFontScaleFactor(scale) to the part. However, the part fails to change the font size in the document frame.
Comment 3 alexpos 2019-12-15 18:21:39 UTC
Can indeed confirm the latter, it does indeed not do *nothing*, it increases and decreases the word next, but not the main help-text.
Comment 4 postix 2019-12-15 19:33:48 UTC
(In reply to alexpos from comment #3)
> it increases and decreases the word next, but not the main help-text.

I still don't see it. O:-)
Comment 5 postix 2019-12-15 19:38:30 UTC
Created attachment 124513 [details]
Video demonstrating my view.

I really don't see anything changing at all. The font of the HTML text is to big, as I had used CTRL + the scroll wheel before.
Comment 6 Yuri Chornoivan 2019-12-15 19:45:14 UTC
(In reply to Postix from comment #5)
> Created attachment 124513 [details]
> Video demonstrating my view.
> 
> I really don't see anything changing at all. The font of the HTML text is to
> big, as I had used CTRL + the scroll wheel before.

Please open some manual to see that "next" (in German) at the top right corner. Thanks.
Comment 7 postix 2019-12-15 19:47:56 UTC
(In reply to Yuri Chornoivan from comment #6)
> Please open some manual to see that "next" (in German) at the top right
> corner. Thanks.

Alright, I can confirm your observation now. The buttons change the labels' size of "back", "next" and the name of the app in the center.
Comment 8 postix 2019-12-15 19:51:01 UTC
(In reply to Yuri Chornoivan from comment #2)
> I would rather say that this is KHTMLPart problem as KHelpCenter itself do
> the right thing sending setFontScaleFactor(scale) to the part. However, the
> part fails to change the font size in the document frame.

Moved it.
Comment 9 postix 2020-01-13 18:14:24 UTC
Things seem to have changed recently. Now the text changes in size but the user needs to open a page (again) in order to let it take effect. 

---

Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Kernel Version: 5.4.6-2-MANJARO
Comment 10 Yuri Chornoivan 2020-01-30 18:55:36 UTC
*** Bug 416960 has been marked as a duplicate of this bug. ***
Comment 11 Yuri Chornoivan 2020-01-30 18:58:00 UTC
It is actually KHelpCenter bug. Sorry for the misguiding.

https://phabricator.kde.org/D27046
Comment 12 Yuri Chornoivan 2020-01-31 06:53:16 UTC
Git commit c56b981f44d64823edcf558d787a995e11a5e29b by Yuri Chornoivan.
Committed on 31/01/2020 at 06:52.
Pushed by yurchor into branch 'release/19.12'.

Reload the page after changing the font size

Summary:
Currently the font size chage does not work because the content is not updated.

Test Plan:
1. Open some help file.
2. Click on the "Increase/Decrease font size" buttons.
3. The size of the font should change.

Reviewers: #kde_applications

Subscribers: kde-doc-english

Tags: #documentation

Differential Revision: https://phabricator.kde.org/D27046

M  +2    -0    view.cpp

https://commits.kde.org/khelpcenter/c56b981f44d64823edcf558d787a995e11a5e29b