Bug 415173 - System settings sidebar home page Plasma icon should not be able to be changed
Summary: System settings sidebar home page Plasma icon should not be able to be changed
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.17.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-14 18:21 UTC by Björn Feber
Modified: 2019-12-21 14:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Feber 2019-12-14 18:21:45 UTC
SUMMARY
The system settings sidebar home page has a Plasma icon ("start-here-symbolic", which is the application launcher icon) that can be changed by the icon theme. This should not be possible, because it would be wrong to have an unrelated menu icon next to a label that says Plasma.
An easy solution would be to remove this icon (if you keep it make sure recoloring still works).

STEPS TO REPRODUCE
1. Use an icon theme that is not Breeze (for example Oxygen or Papirus)
2. Open System Settings with the sidebar view mode set

OBSERVED RESULT
The Plasma icon is different from the real logo.

EXPECTED RESULT
The Plasma icon is the same as the real logo or is not there.
Comment 1 Filip Fila 2019-12-14 23:53:16 UTC
Can't we just ship this icon in the system settings repo, install it to a specific place and have the code point to it?
Comment 2 Björn Feber 2019-12-15 09:30:51 UTC
(In reply to Filip Fila from comment #1)
> Can't we just ship this icon in the system settings repo, install it to a
> specific place and have the code point to it?

AFAIK then recoloring stops working.
Comment 3 David Redondo 2019-12-21 14:55:42 UTC
Git commit 957c5cf9e44ee31c26fcc8e1613ff1d3ad4f66ac by David Redondo.
Committed on 21/12/2019 at 14:55.
Pushed by davidre into branch 'master'.

Ship plasma-logo in repo

Summary:
We don't want the plasma-logo on the homepage to be changed to something else by
the icon theme. It's not used like an icon but as a logo and should always
display our brand.

Test Plan: Open systemsettings with different icon and color themes

Reviewers: #plasma, GB_2, ngraham

Reviewed By: GB_2, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26078

A  +4    -0    sidebar/package/contents/images/plasma-logo.svg
M  +3    -1    sidebar/package/contents/ui/introPage.qml

https://commits.kde.org/systemsettings/957c5cf9e44ee31c26fcc8e1613ff1d3ad4f66ac