Bug 414993 - Low contrast for selection with light gray text on Breeze dark at Network manager
Summary: Low contrast for selection with light gray text on Breeze dark at Network man...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Networks widget (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Jan Grulich
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2019-12-09 19:22 UTC by postix
Modified: 2024-12-23 18:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0
Sentry Crash Report:


Attachments
Screenshot of the issue. (147.20 KB, image/png)
2019-12-09 19:22 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-12-09 19:22:45 UTC
Created attachment 124404 [details]
Screenshot of the issue.

The current blue background color for an hovered item has in my humble opinion a too low contrast compared to the content.
Hence this results in a bad legibility. 

This is especially the case if you open the details for your connection in the Network Manager, as you can see it in the attached screenshot.
The details / bandwidth is very blue'ish while hovered.

Additionally this brings me to the next pint, which however should probably be reported against the nm applet itself:
I am not sure if it really needs this blue "hover" background at all, if the user clicks on a connection. I think it'd be enough to only draw a blue background on the upper part above the separation line (which separates the connection name from bandwith / details).
Comment 1 Nate Graham 2019-12-12 17:37:32 UTC
Really this is a bug in the network manager on two points:
- It should not use super transparent text here
- It should draw the hover highlight over the expanded area when expanded

Let's fix it there.
Comment 2 Nate Graham 2019-12-13 21:17:32 UTC
First patch: https://phabricator.kde.org/D25970
Comment 3 Nate Graham 2019-12-14 15:18:24 UTC
Git commit 00be92a520e6f6d392f1d2df409b086bef9526d0 by Nate Graham.
Committed on 14/12/2019 at 15:18.
Pushed by ngraham into branch 'master'.

[applet] Make details text fully opaque and normal style

Summary:
There isn't any need to make the labels bold and all the text almost half transparent.
The view is just fine without them, and the current style is quite low-contrast with a
dark theme.
FIXED-IN: 5.18.0

Test Plan:
{F7816994}
{F7816993}

Reviewers: #vdg, jgrulich, ndavis

Reviewed By: #vdg, jgrulich, ndavis

Subscribers: ndavis, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25970

M  +1    -3    applet/contents/ui/DetailsText.qml

https://commits.kde.org/plasma-nm/00be92a520e6f6d392f1d2df409b086bef9526d0
Comment 4 Ben Cooksley 2024-12-23 18:25:52 UTC
Bulk transfer as requested in T17796