Bug 414968 - Using provided custom colour package Midnight Commander, renaming files is difficult, as line colours are very pale.
Summary: Using provided custom colour package Midnight Commander, renaming files is di...
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: 2.6.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Davide Gianforte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-08 23:12 UTC by subnormalx
Modified: 2020-06-03 06:13 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot showing how pale the colours are while editing a filename. (12.46 KB, image/png)
2019-12-29 16:42 UTC, subnormalx
Details
Showing the provided colour schemes that come with Krusader (26.65 KB, image/png)
2019-12-29 16:44 UTC, subnormalx
Details
where the color-scheme can be found (202.07 KB, image/png)
2020-05-28 20:47 UTC, Toni Asensi Esteve
Details
The bug is not seen using Kubuntu 20.04 (21.09 KB, image/png)
2020-05-28 20:53 UTC, Toni Asensi Esteve
Details
The bug is not seen using Ubuntu 18.04 (100.08 KB, image/png)
2020-05-28 21:10 UTC, Toni Asensi Esteve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description subnormalx 2019-12-08 23:12:22 UTC
SUMMARY


STEPS TO REPRODUCE
1. Import colour scheme - Midnight Commander
2. Pick a file to rename
3. Observe all 3 colours (selected, unselected foreground and background) of the current line are quite pale.  
4. None of the colours in this specific instance can be modified - None of the customization options or colour scheme in Midnight Commander appear to change the colour of this.

OBSERVED AND EXPECTED RESULT

Colours on the rename selected file line appear very pale (white and light grey) when they should be constrasted, legible.  The specific colours here are also uncustomizable in the provided Midnight Commander colour theme.  It makes renaming files much more difficult than it should be.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Version 2.6.0 "Stiff Challenges"
(available in About System)
KDE Plasma Version: ?
KDE Frameworks Version: KDE Frameworks 5.44.0
Qt Version: Qt 5.9.5 (built against 5.9.5)

ADDITIONAL INFORMATION
The xcb windowing system
Comment 1 Davide Gianforte 2019-12-29 16:07:12 UTC
I wasn't able to find the color scheme, can you send a screenshot or the color scheme?
Comment 2 subnormalx 2019-12-29 16:42:38 UTC
Created attachment 124774 [details]
Screenshot showing how pale the colours are while editing a filename.

Using midnight commander colour scheme as it is the only dark-mode colour template provided, the others are brighter and constrasted suitably.  The colours shown in the editing bar seem unable to be modified to contrast suitably.
Comment 3 subnormalx 2019-12-29 16:44:42 UTC
Created attachment 124776 [details]
Showing the provided colour schemes that come with Krusader
Comment 4 Bug Janitor Service 2020-01-13 04:33:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Christoph Feck 2020-01-13 11:07:09 UTC
Information was provided with comment 2 and comment 3; changing status for inspection.
Comment 6 Toni Asensi Esteve 2020-05-28 20:47:12 UTC
Created attachment 128880 [details]
where the color-scheme can be found


> I wasn't able to find the color scheme, can you send 
> a screenshot or the color scheme?            
The color-scheme is not very easy to find, it can be selected after pressing the «Import color-scheme» button. I attach a screenshot.
Comment 7 Toni Asensi Esteve 2020-05-28 20:53:27 UTC
Created attachment 128882 [details]
The bug is not seen using Kubuntu 20.04

Using Kubuntu 20.04 I didn't find the bug. I attach a screenshot.
                
However, I remember having seen the effects of the bug (months ago) using Mate and Krusader 2.4.0-beta3. Maybe it has to do with the "The xcb windowing system" of the bug reporter, with his Krusader version, or with both.
Comment 8 Toni Asensi Esteve 2020-05-28 21:10:56 UTC
Created attachment 128884 [details]
The bug is not seen using Ubuntu 18.04

Using a virtual machine with Ubuntu 18.04: the bug wasn't seen.
Comment 9 Davide Gianforte 2020-06-03 06:13:08 UTC
Git commit 1afe484b6931ce8239a0031e3fbaa4dfd05ca8a6 by Davide Gianforte.
Committed on 03/06/2020 at 06:13.
Pushed by gengisdave into branch 'master'.

Configurable colors to rename line

Add to Konfigurator two options to set foreground and background colors to be
applied to the rename field.
Related: bug 301034
FIXED: [ 301034 ] Rename input field doesn't respect text[NORMAL] when GTK theme is used
FIXED: [ 414968 ] Using provided custom colour package Midnight Commander, renaming files is difficult, as line colours are very pale.
ADDED: In Konfigurator, two options are added to set foreground and background colors to the rename field.
GUI: Two new options ("Rename background" and "Rename foreground") are seen by users.

M  +2    -0    krusader/Konfigurator/kgcolors.cpp
M  +15   -0    krusader/Panel/PanelView/krviewitemdelegate.cpp
M  +2    -0    krusader/Panel/krcolorcache.cpp

https://invent.kde.org/utilities/krusader/commit/1afe484b6931ce8239a0031e3fbaa4dfd05ca8a6