Bug 414841 - Crash with invalid or failed TLS authentication
Summary: Crash with invalid or failed TLS authentication
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: android-application (show other bugs)
Version: 1.3.5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-04 22:56 UTC by Andy Holmes
Modified: 2020-04-18 03:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
tombstone file from android (367.34 KB, patch)
2019-12-04 22:56 UTC, Andy Holmes
Details
partial adb log from crash (13.62 KB, text/plain)
2019-12-04 22:58 UTC, Andy Holmes
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Holmes 2019-12-04 22:56:59 UTC
Created attachment 124323 [details]
tombstone file from android

SUMMARY

On virtually any TLS error, including sending an invalid/corrupted certificate or just bailing during the handshake, the Android app will crash.


STEPS TO REPRODUCE
1. Setup two devices with a KDE Connect client, at least one with the Android app
2. Attempt to connect with a faulty certificate or just close the connection during authentication
3. 

OBSERVED RESULT

kdeconnect-android crashes, usually restarting and crashing again when the device attempts to handshake again

EXPECTED RESULT

Probably the connection should close, or ideally prompt the user about a possible fraudulent connection attempt.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

I reproduced this with GSConnect, but no doubt it's possible to create this issue with kdeconnect-kde. It's rare to happen in the wild, but tends to happen when users do silly things like change their hostname or try copy settings between machines.
Comment 1 Andy Holmes 2019-12-04 22:58:44 UTC
Created attachment 124324 [details]
partial adb log from crash