Bug 414831 - cant focus embedded terminal with ctrl+down
Summary: cant focus embedded terminal with ctrl+down
Status: ASSIGNED
Alias: None
Product: krusader
Classification: Applications
Component: shortcuts (show other bugs)
Version: 2.7.2
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-04 16:47 UTC by merchamion
Modified: 2020-01-02 17:30 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description merchamion 2019-12-04 16:47:55 UTC
SUMMARY
cant focus embedded terminal with ctrl+down

STEPS TO REPRODUCE
1. open embedded terminal ctrl+shift+T
2. try to focus embedded terminal with ctrl+down (as in https://docs.kde.org/stable5/en/extragear-utils/krusader/cmdline_termemu.html)

OBSERVED RESULT
focus stays in active panel. only way to 


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 merchamion 2019-12-04 16:53:17 UTC
SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  plasma 5.17.3
(available in About System)
KDE Plasma Version: plasma 5.17.3
KDE Frameworks Version: plasma-framework 5.64
Qt Version: 5.9
Comment 2 mischiew 2019-12-23 21:39:57 UTC
Same. Actually I can't focus on the embedded terminal at all, even trying other shortcuts either in the main or secondary shortcut.

Most of the shortcuts shown in the Krusader Handbook seem out-of-date.

(Not sure this project is still alive though, just posting this for reference)
Comment 3 Davide Gianforte 2019-12-28 19:36:02 UTC
You can move to and from the embedded terminal with the "Move Focus Down" and "Move Focus Up" commands (default shortcuts: CTRL+SHIFT+DOWN and CTRL+SHIFT+UP). Those command let you also to navigate the sidebar in the panel, while CTRL+UP/DOWN can't. This last commands are hardcoded and let you to move also into the location bar to edit it.

Before upgrading the documentation, I would try to make this situation better.
Comment 4 Davide Gianforte 2020-01-01 11:02:13 UTC
Proposed patch: https://phabricator.kde.org/D26291
Comment 5 mischiew 2020-01-01 11:15:44 UTC
(In reply to Davide Gianforte from comment #3)
> You can move to and from the embedded terminal with the "Move Focus Down"
> and "Move Focus Up" commands (default shortcuts: CTRL+SHIFT+DOWN and
> CTRL+SHIFT+UP). Those command let you also to navigate the sidebar in the
> panel, while CTRL+UP/DOWN can't. This last commands are hardcoded and let
> you to move also into the location bar to edit it.
> 
> Before upgrading the documentation, I would try to make this situation
> better.

Not sure about the OP, but actually I can't, none of those allow to focus on the embedded terminal, even the hard-coded ones. The only way to focus right now is the mouse, but the point of those tools is to bypass the mouse and be more efficient.

I don't have an exotic keyboard, it's a standard AZERTY, but those keys should be the same as a QWERTY or QWERTZ (not sure where the OP or the author of this code is coming from).

None of those shortcuts is taken by the desktop environment either, so I don't see any intercepting as an explanation.

Don't hesitate to ask for specific information or log files if that helps.
Comment 6 mischiew 2020-01-01 11:57:11 UTC
I did a few tests to be more specific.

  Operating System: openSUSE Tumbleweed
       CPE OS Name: cpe:/o:opensuse:tumbleweed:20191028
            Kernel: Linux 5.3.7-1-default
      Architecture: x86-64

KDE Plasma Version: 5.17.1
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Kernel Version: 5.3.7-1-default
OS Type: 64-bit
Processors: 8 × Intel® Core™ i5-8259U CPU @ 2.30GHz
Memory: 15,5 GiB of RAM

Current shortcut settings (didn't find the config file):
Move Focus Down: shortcut = Ctrl+Shift+Down, Alternate = Alt+PgDn
Move Focus Up:   shortcut = Ctrl+Shift+Up,   Alternate = Alt+PgUp

(I tried other alternates)

1) When focused in the file panel, for ex. the left panel,
- Ctrl+Shift+Up: no effect (not expected?)
- Ctrl+Shift+Dn: no effect (not expected?)
- Alt+PgUp: no effect (not expected?)
- Alt+PgDn: no effect (not expected?)
- Ctrl+Up: focus in the directory name just above the panel (OK)
- Ctrl+Dn: no effect (not expected?)

2) When focused in the embedded terminal panel (done with mouse)
- Ctrl+Shift+Up: focus in file panel (OK)
  (doing Ctrl+Shift+Dn right after has no effect)
- Ctrl+Shift+Dn: no effect (OK)
- Ctrl+Up: focus in file panel (OK)
  (doing Ctrl+Dn right after has no effect)
- Ctrl+Dn: no effect (OK)
- Alt+PgUp: previous history command (not expected?)
- Alt+PgDn: next history command (not expected?)
Comment 7 Davide Gianforte 2020-01-01 17:21:30 UTC
(In reply to mischiew from comment #6)
> 1) When focused in the file panel, for ex. the left panel,
> - Ctrl+Shift+Up: no effect (not expected?)
Not working at the moment

> - Ctrl+Shift+Dn: no effect (not expected?)
You should move to Sidebar, Terminal or Command Line, the first visible widget in this order. If you do this after focusing the panel and then you write some text, do you get a fast search or write into the Terminal or Command line? When you change focus, the graphic is not always helpful.

> - Ctrl+Up: focus in the directory name just above the panel (OK)
You should move to the location bar, activating editing mode as you confirmed.

> - Ctrl+Dn: no effect (not expected?)
You should move to the command line.

> 2) When focused in the embedded terminal panel (done with mouse)
> - Ctrl+Shift+Up: focus in file panel (OK)
>   (doing Ctrl+Shift+Dn right after has no effect)
The second keystroke should move you back to the terminal

> - Ctrl+Shift+Dn: no effect (OK)
You should move to the command line

> - Ctrl+Up: focus in file panel (OK)
>   (doing Ctrl+Dn right after has no effect)
The second keystroke should move you to the command line

> - Ctrl+Dn: no effect (OK)
You should move to the command line
Comment 8 mischiew 2020-01-02 17:30:56 UTC
(In reply to Davide Gianforte from comment #7)
> > 1) When focused in the file panel, for ex. the left panel,
> > - Ctrl+Shift+Dn: no effect (not expected?)
> You should move to Sidebar, Terminal or Command Line, the first visible
> widget in this order. If you do this after focusing the panel and then you
> write some text, do you get a fast search or write into the Terminal or
> Command line? When you change focus, the graphic is not always helpful.

I don't see any effect, no change of focus or behaviour whatsoever, no matter how many times I use this key combination or any alternate mapping that I tried.
 
If I focus on the file panel, then type some text, it focuses on the search/filter field, using Ctrl-Shift-Dn or alternate from there has no effect.

Same from the terminal.

> > - Ctrl+Dn: no effect (not expected?)
> You should move to the command line.

Same as above (Ctrl-Shift-Dn), no effect at all.

> > 2) When focused in the embedded terminal panel (done with mouse)
> > - Ctrl+Shift+Up: focus in file panel (OK)
> >   (doing Ctrl+Shift+Dn right after has no effect)
> The second keystroke should move you back to the terminal
> 
> > - Ctrl+Shift+Dn: no effect (OK)
> You should move to the command line
> 
> > - Ctrl+Up: focus in file panel (OK)
> >   (doing Ctrl+Dn right after has no effect)
> The second keystroke should move you to the command line
> 
> > - Ctrl+Dn: no effect (OK)
> You should move to the command line

None of those work with me.

Additional info:

- I mapped Ctrl-Shift-Dn to another function, History, and I get the expected history when I use this key combination (tested just to make sure one of the mapping is not captured by something else).

- I tried the "Set Focus to the Panel" too, and if I try from the terminal it is ignored (even alternate mappings). It works from the search/filter field though (tested to verify other focus-related functions).