Bug 414694 - No visible way to show/hide the sidebar in full screen mode
Summary: No visible way to show/hide the sidebar in full screen mode
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 19.08.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords: junior-jobs, usability
Depends on:
Blocks:
 
Reported: 2019-11-30 16:46 UTC by postix
Modified: 2019-12-26 16:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.04.0


Attachments
Screenshot of the sidebar in full screen mode. (238.57 KB, image/png)
2019-11-30 16:46 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-11-30 16:46:45 UTC
Created attachment 124214 [details]
Screenshot of the sidebar in full screen mode.

SUMMARY

In the full screen mode the sidebar becomes automatically visible, but it is not possible to hide the sidebar at all.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.3
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.2
Comment 1 Nate Graham 2019-12-02 20:54:17 UTC
You have to use the keyboars shortcut, which is F4. Not very intuitive, I know. There are a few ways I could see fixing this:
- Always show the menubar in full screen mode
- In full screen mode, show the menubar when the mouse touches the top of the screen
- Add a button on the full-screen toolbar for showing and hiding the sidebar.

All are pretty easy. Marking this as a junior job for someone enterprising. :)
Comment 2 postix 2019-12-02 21:07:23 UTC
(In reply to Nate Graham from comment #1)
> You have to use the keyboars shortcut, which is F4. Not very intuitive, I
> know. 

That's good to know!

> - Always show the menubar in full screen mode
I don't think that this is a good solution at all, especially if the full screen mode is considered being a dia show, which I use it for.

> - In full screen mode, show the menubar when the mouse touches the top of
> the screen

Currently it shows the the preview and the controls to move between the images etc.
I think adding a button on the left there would be an easy solution, which would not disturb much.

> - Add a button on the full-screen toolbar for showing and hiding the sidebar.
A button for hiding is convenient, but a button for showing may disturb the plain view of the image.

> 
> All are pretty easy. Marking this as a junior job for someone enterprising.
> :)

I wish I had the time .. :-(
Comment 3 Nate Graham 2019-12-26 15:20:52 UTC
Git commit db6ca614a41eb880c2eee9d34101b17400dd5ca1 by Nate Graham, on behalf of Madhav Kanbur.
Committed on 26/12/2019 at 15:20.
Pushed by ngraham into branch 'master'.

Add button to toggle sidebar in fullscreen mode

Summary:
Previously, there was no way to toggle the sidebar in
fullscreen view mode except for the keyboard shortcut F4. This patch
adds a button to toggle the sidebar from the fullscreen toolbar.

Test Plan:
Tested the button in fullscreen (view) mode. Button works
as expected, and preserves existing behavior of all other sidebar
toggle mechanisms as well.

Reviewers: #vdg, #gwenview, ngraham

Subscribers: #gwenview

Tags: #gwenview

Differential Revision: https://phabricator.kde.org/D26230

M  +2    -0    app/fullscreencontent.cpp

https://commits.kde.org/gwenview/db6ca614a41eb880c2eee9d34101b17400dd5ca1