Bug 414641 - coordinate precision cannot be changed
Summary: coordinate precision cannot be changed
Status: RESOLVED FIXED
Alias: None
Product: kig
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David E. Narvaez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-28 23:48 UTC by Maurizio Paolini
Modified: 2019-12-23 04:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: release service 19.12.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maurizio Paolini 2019-11-28 23:48:47 UTC
Description of problem: the number of decimal digits displayed in labels cannot be changed


Version-Release number of selected component (if applicable):
latest Git source


How reproducible: There is an input panel for changing the value, but it is
missing an "OK" button!


Steps to Reproduce:
1. Start kig
2. Open "Settings" menu
3. Chose "Set coordinate precision"

Actual results:
You can cange the number in the input field, but there is no way to
accept the value (no "OK" button visible)
Comment 1 Kevin Kofler 2019-11-29 00:08:38 UTC
As I wrote in the downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1311513
I can confirm this. It is easily reproducible: the dialog has no OK button (nor a Cancel nor Close button for that matter), and closing it through the title bar's close button does not save the settings, so they are lost no matter what you do.
Comment 2 Christoph Feck 2019-12-19 21:44:17 UTC
It looks like the commit that ported from KDialog to QDialog was already made in 2014. Adding the QDialogButtonBox is needed when porting.
Comment 3 David E. Narvaez 2019-12-23 04:42:11 UTC
Git commit 63e4bc0f9f82162f3b78f0c565c29359ae906ec2 by David E. Narváez.
Committed on 23/12/2019 at 04:42.
Pushed by narvaez into branch 'release/19.12'.

Add a QDialogButtonBox to the Coordinate Precision Dialog

Summary:
This was missing from the migration to Frameworks.

Test Plan: 1) Go to "Settings -> Set Coordinate Precision..." and change the coordinate precision

Reviewers: #kde_edu, apol

Reviewed By: apol

Subscribers: kde-edu

Tags: #kde_edu

Differential Revision: https://phabricator.kde.org/D26166

M  +7    -3    misc/kigcoordinateprecisiondialog.cpp

https://commits.kde.org/kig/63e4bc0f9f82162f3b78f0c565c29359ae906ec2