Bug 414630 - shortcut bug in caption (tag)
Summary: shortcut bug in caption (tag)
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Captions (other bugs)
Version First Reported In: 6.4.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-28 19:06 UTC by majid_casting@yahoo.com
Modified: 2022-01-07 05:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 7.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description majid_casting@yahoo.com 2019-11-28 19:06:15 UTC
in version 6.3 and older when I typed the words in tag's textbox ,the list of tags had shown for me below the textbox that I could select the desired tag from tag list and when tag textbox was empty I could change the image with arrow key( for fast tag management I had set shortcut with arrow key ("up"for previous image and "down" for next image)). but in this version when I type letters of word, and click on "up" or "down" on keyboard for selecting the desired tag I can't select desired tag from tag list and instead it changes image.   
this bug didn't exist in version 6.3 and older


SOFTWARE/OS VERSIONS
Windows: 7
Comment 1 Maik Qualmann 2019-11-29 08:37:01 UTC
There were actually no changes here. But, do not define up/down as a shortcut for switching images. This is already set as far as possible in digiKam. The tag popup always uses up/down to select the tags (not changeable). Use image up/down to change the image.

Maik
Comment 2 majid_casting@yahoo.com 2019-11-29 09:03:00 UTC
dear Maik I used digikam from version 5 to 6.3 and I had defined up/down as a shortcut for switching images without any problem and default shortcut is space and backspace that makes other problem! and I used digikam for all of mine photos and when I send this bug it is exist then please test version 6.3 and if you don't understand the bug say to me for more explain. and I roll back to version 6.3 only for this bug (this problem is not usual).
Comment 3 majid_casting@yahoo.com 2019-11-29 09:56:09 UTC
I took a video from screen. the version of digikam that is used is 6.3 and I had defined up/down as a shortcut for switching images but when I type a letter in textbox, the up/down shortcut temporary disabled for image changing and instead I can use up/down for selecting the desire tag and when I select a tag or empty text box, again I can use up/down for switching images. but in version 6.4 I can't use this option; and that is not user friendly at all.
link of video: https://mega.nz/#!iMMTGA7L!gSa9dHS2RmF2I3aSj4vlNiLJ80mssnjoUciiuHpPPMQ
Comment 4 Maik Qualmann 2019-11-29 12:01:48 UTC
There seems to have been a change in Qt here. However, it was never intended that up/down is manual defined for image change, since it is already set internally. I will see if I can restore the desired behavior.

Maik
Comment 5 Maik Qualmann 2019-11-29 19:15:28 UTC
Git commit 31f3d8edd34c4c246ac1933522a0430038e42e5f by Maik Qualmann.
Committed on 29/11/2019 at 19:14.
Pushed by mqualmann into branch 'master'.

add up/down key in the new tag edit to switch images
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +20   -1    core/libs/properties/captions/itemdescedittab.cpp

https://invent.kde.org/kde/digikam/commit/31f3d8edd34c4c246ac1933522a0430038e42e5f
Comment 6 Maik Qualmann 2019-11-29 19:17:50 UTC
Note: the up/down keys must not be defined as shortcuts in the dialog.

Maik
Comment 7 majid_casting@yahoo.com 2019-11-30 08:55:02 UTC
dear Maik I installed last weekly version today(https://files.kde.org/digikam/digiKam-7.0.0-git-20191129T191911-Win64.exe.mirrorlist) that I think you are fixed the this bug. but the bug is exist yet still. I think that you didn't understand what is problem. I don't want you "add up/down key in the new tag edit to switch images" Because this option is set in v 6.4 and the problem is from that. In version 6.3 I had defined up/down as a shortcut for switching images but >>> when I type a letter in textbox, the up/down shortcut "temporary disabled" for image changing<< and instead I can use up/down for selecting the desire tag and "when I select a tag or empty text box, again I can use up/down for switching images". but in version 6.4 I can't use this option;
Comment 8 Maik Qualmann 2019-11-30 09:00:29 UTC
The Windows bundle does not yet contain the change that takes at least one hour to compile. Only when Gilles compiles a new bundle today will the change be included. I understood the problem very well, when the popup list is displayed, you can only select up/down in the list.

Maik
Comment 9 Maik Qualmann 2019-11-30 09:07:20 UTC
And again the hint, with the version digiKam-7.0.0 you have to delete your defined up/down keys. The issue was triggered by a change in Qt (we have no influence on that), so we must now actively program this feature.

Maik
Comment 10 caulier.gilles 2019-11-30 09:38:57 UTC
The bundle compilation will be stated today morning.

Gilles
Comment 11 majid_casting@yahoo.com 2019-11-30 09:49:47 UTC
Thanks for your responsibility and have nice days in new year.
best regard.(In reply to Maik Qualmann from comment #8)
> The Windows bundle does not yet contain the change that takes at least one
> hour to compile. Only when Gilles compiles a new bundle today will the
> change be included. I understood the problem very well, when the popup list
> is displayed, you can only select up/down in the list.
> 
> Maik

Thanks for your responsibility and I wish nice days for you and your colleagues.