Bug 414581 - Triangles appears over vector shapes with 'stroke' layer style
Summary: Triangles appears over vector shapes with 'stroke' layer style
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layers/Vector (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-27 18:05 UTC by acc4commissions
Modified: 2020-06-03 19:50 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
(capture) (34.20 KB, image/png)
2019-11-27 18:05 UTC, acc4commissions
Details
the file (448.84 KB, application/x-krita)
2019-12-04 16:34 UTC, acc4commissions
Details

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2019-11-27 18:05:32 UTC
Created attachment 124146 [details]
(capture)

SUMMARY
git d19b0b6

Triangles appears over vector shapes with 'stroke' layer style.
It doesn't seem to happen in 4.2.8.


STEPS TO REPRODUCE
1. Draw vector shapes and texts on a vector layer
2. Apply the layer style(Stroke)
3. Change parameters of the effect

OBSERVED RESULT
Random triangles in the same color with the fill color appears.

EXPECTED RESULT
Nothing appears.

SOFTWARE/OS VERSIONS
Windows: Win7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2019-12-04 13:06:00 UTC
Hm, I cannot reproduce this in master. Could you maybe attach the file that shows the problem?
Comment 2 acc4commissions 2019-12-04 16:34:17 UTC
Created attachment 124315 [details]
the file
Comment 3 Bug Janitor Service 2019-12-05 04:33:10 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 4 Halla Rempt 2019-12-05 14:54:46 UTC
Worse... Loading the file asserts in master: 

ASSERT: "!namedTransactionInProgress()" in file /home/boud/dev/krita/libs/image/tiles3/kis_memento_manager.cc, line 238
Comment 5 acc4commissions 2020-01-28 01:21:22 UTC
This doesn't seem to happen anymore in the latest nightlies, but the original file I saved for this bug report still have this. Maybe the bug itself has been already fixed in krita, but I'm not sure...
Comment 6 acc4commissions 2020-01-28 02:23:19 UTC
Oh, it's not. Tested again, it sometimes happen in the latest nightly. :/ but I can't catch exactly when. I'll post more as I get more informations.
Comment 7 Dmitry Kazakov 2020-06-03 13:40:51 UTC
I can reproduce the issue. The problem happens because there seem to be some leftovers of the vector shapes still painted on the vector layer's projection. They are not normally visible in the canvas.
Comment 8 Dmitry Kazakov 2020-06-03 19:49:08 UTC
Git commit fe52e776655c378d1632a8305f8c7dc60b5a405a by Dmitry Kazakov.
Committed on 03/06/2020 at 19:41.
Pushed by dkazakov into branch 'krita/4.3'.

Fix leftover artifacts when moving shapes under layer styles

We should actually crop rendering area by job.viewUpdateRect. There
was a long-standing todo notice for that ;)

M  +39   -13   libs/ui/flake/kis_shape_layer_canvas.cpp

https://invent.kde.org/graphics/krita/commit/fe52e776655c378d1632a8305f8c7dc60b5a405a
Comment 9 Dmitry Kazakov 2020-06-03 19:50:07 UTC
Git commit 5305eb0d99956d18eaece0cf19ca5a27c7af9d1d by Dmitry Kazakov.
Committed on 03/06/2020 at 19:49.
Pushed by dkazakov into branch 'master'.

Fix leftover artifacts when moving shapes under layer styles

We should actually crop rendering area by job.viewUpdateRect. There
was a long-standing todo notice for that ;)

M  +39   -13   libs/ui/flake/kis_shape_layer_canvas.cpp

https://invent.kde.org/graphics/krita/commit/5305eb0d99956d18eaece0cf19ca5a27c7af9d1d